IPAM: Add CIDR label to IPAM capacity metric#44541
Conversation
117d9ba to
db2ce71
Compare
chancez
left a comment
There was a problem hiding this comment.
CIDRs are basically configured by the user right? So it should be relatively bounded in the number of CIDRs we would expect to see? Just worried about metric cardinality. If this is user controlled it's probably fine. If CIDRs allocated/deallocated it could be an issue.
db2ce71 to
0219dc0
Compare
After double checking the code it looks CIDRs are manually configured by the user except in the case of ENI IPAM in which the cloud controller configures CIDRs. However, these CIDRs can only come from the range of IP addresses available to the VPC which is user controlled. Therefore I don't think cardinality would be a concern here. |
|
I believe that a rebase against tip of |
0219dc0 to
40d2ef0
Compare
|
@soggiest this will need a rebase. Perfect opportunity to address Sebastian's nitpick :) |
40d2ef0 to
2945272
Compare
Finally back from vacation, took care of both :D |
This commit adds a new metric label and assigns it to the Cilium agent's IPAM capacity metric. Tracking the capacity of CIDRs used across a cluster will be significantly easier with this label in place. Signed-off-by: Soggiest <lanen@cisco.com>
2945272 to
aa6f497
Compare
|
/test |
This commit adds a new metric label and assigns it to the Cilium agent's IPAM capacity metric. Tracking the capacity of CIDRs used across a cluster will be significantly easier with this label in place.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.