node/neighbordiscovery: correctly update and delete node IPv6 addresses#44540
Merged
node/neighbordiscovery: correctly update and delete node IPv6 addresses#44540
Conversation
The logic in (*nodeNeighborHandler).NodeUpdate and (*nodeNeighborHandler).NodeDelete treats the node IPv4 address retrieved using node.GetNodeIP(false) (where false means ipv6=false) as an IPv6 address. This will lead to the address not correctly compared and propagated to the forwardableIPManager. Correct this by retrieving the node IPv6 address consistently for the IPv6 paths. Also rename an incorrectly named local variable in (*nodeNeighborHandler).NodeAdd while at it. Fixes: ccb7bd1 ("pkg/node/neighbordiscovery: Add node handler for neighbor discovery") Signed-off-by: Tobias Klauser <tobias@cilium.io>
Member
Author
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic in
(*nodeNeighborHandler).NodeUpdateand(*nodeNeighborHandler).NodeDeletetreats the node IPv4 address retrieved usingnode.GetNodeIP(false)(wherefalsemeansipv6=false) as an IPv6 address. This will lead to the address not correctly compared and propagated to theforwardableIPManager.Correct this by retrieving the node IPv6 address consistently for the IPv6 paths.
Also rename an incorrectly named local variable in
(*nodeNeighborHandler).NodeAddwhile at it.Fixes: ccb7bd1 ("pkg/node/neighbordiscovery: Add node handler for neighbor discovery")