Skip to content

bgp: Ensure unique job names for BGPCPResourceStore instances#44514

Merged
julianwiedmann merged 1 commit intocilium:mainfrom
rastislavs:bgp-resource-store-job
Feb 25, 2026
Merged

bgp: Ensure unique job names for BGPCPResourceStore instances#44514
julianwiedmann merged 1 commit intocilium:mainfrom
rastislavs:bgp-resource-store-job

Conversation

@rastislavs
Copy link
Copy Markdown
Contributor

@rastislavs rastislavs commented Feb 24, 2026 •
edited
Loading

Ensure each tracked resource uses unique job name. Duplicate job names are harder to debug, and produce errors upon hive termination, such as:

level=ERROR msg="failed to delete reporter status tree" module=health error="reporting for "bgp-control-plane.job-bgpcp-resource-store-events" has been stopped

bgp: Ensure unique job names for `BGPCPResourceStore` instances to avoid error logs during hive termination

@rastislavs
bgp: Ensure unique job names in BGPCPResourceStore
db4daec 
Ensure each tracked resource uses unique job name.
Duplicate job names are harder to debug, and produce
errors upon hive termination, such as:

```
msg="failed to delete reporter status tree" module=health
error="reporting for "bgp-control-plane.job-bgpcp-resource-store-events"
has been stopped
```

Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
@rastislavs rastislavs added release-note/misc This PR makes changes that have no direct user impact. area/bgp Impacts the Border Gateway Protocol feature. labels Feb 24, 2026
@rastislavs
Copy link
Copy Markdown
Contributor Author

rastislavs commented Feb 24, 2026

/test

@rastislavs rastislavs marked this pull request as ready for review February 24, 2026 20:03
@rastislavs rastislavs requested a review from a team as a code owner February 24, 2026 20:03
YutaroHayakawa
YutaroHayakawa approved these changes Feb 24, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@YutaroHayakawa YutaroHayakawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 25, 2026
@julianwiedmann julianwiedmann added this pull request to the merge queue Feb 25, 2026
Merged via the queue into cilium:main with commit fed95cb Feb 25, 2026
82 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YutaroHayakawa YutaroHayakawa YutaroHayakawa approved these changes

Assignees

No one assigned

Labels

area/bgp Impacts the Border Gateway Protocol feature. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rastislavs @YutaroHayakawa @msune @julianwiedmann