clustermesh: fix endpointslicesync cleanup race condition#44503
Merged
MrFreezeex merged 1 commit intocilium:mainfrom Feb 24, 2026
Merged
clustermesh: fix endpointslicesync cleanup race condition#44503MrFreezeex merged 1 commit intocilium:mainfrom
MrFreezeex merged 1 commit intocilium:mainfrom
Conversation
Member
Author
|
/test |
9d045ef to
304e26b
Compare
The cleanup logic was relying on the informer to list EndpointSlice to delete which is racy since the informer is updated asynchronously/separately through its own watch rather than acting as a write through cache. The cleanup logic which is invoked on a cluster removal is modified in this commit to thus directly rely on the client instead. This could was actually reproducible with the existing endpointslicesync test at small rate (~0.1%). Signed-off-by: Arthur Outhenin-Chalandre <git@mrfreezeex.fr>
304e26b to
e74bff2
Compare
Member
Author
|
/test |
jrajahalme
approved these changes
Feb 24, 2026
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cleanup logic was relying on the informer to list EndpointSlice to delete which is racy since the informer is updated asynchronously/separately through its own watch rather than acting as a write through cache.
The cleanup logic which is invoked on a cluster removal is modified in this commit to thus directly rely on the client instead. This could was actually reproducible with the existing endpointslicesync test at at small rate (~0.1%).