Skip to content

install: grant Cilium operator to update ServiceImport finalizers#44458

Merged
gandro merged 1 commit intomainfrom
pr/mrfreezeex/mcs-api-ownerrefperm
Feb 23, 2026
Merged

install: grant Cilium operator to update ServiceImport finalizers#44458
gandro merged 1 commit intomainfrom
pr/mrfreezeex/mcs-api-ownerrefperm

Conversation

@MrFreezeex
Copy link
Copy Markdown
Member

This is required when the OwnerReferencesPermissionEnforcement admission plugin is set, because the operator creates derived Services resources owned by the corresponding ingress, with the blockOwnerDeletion flag set.

Similar PR as #43949 fixing it for the MCS-API cases (kudos to @fgiloux @giorio94 for the existing work made there, this was spotted when integrating the MCS-API conformance test suite in CI)

Grant permissions to the cilium-operator so that it can reconcile ServiceImport when the when the admission plugin OwnerReferencesPermissionEnforcement is activated

This is required when the OwnerReferencesPermissionEnforcement admission
plugin is set, because the operator creates derived Services resources
owned by the corresponding ingress, with the blockOwnerDeletion flag set.

Signed-off-by: Arthur Outhenin-Chalandre <git@mrfreezeex.fr>
@MrFreezeex MrFreezeex requested a review from a team as a code owner February 20, 2026 17:20
@MrFreezeex MrFreezeex requested a review from gandro February 20, 2026 17:20
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 20, 2026
@MrFreezeex MrFreezeex added kind/bug This is a bug in the Cilium logic. area/clustermesh Relates to multi-cluster routing functionality in Cilium. area/helm Impacts helm charts and user deployment experience needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Feb 20, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 20, 2026
@MrFreezeex MrFreezeex added release-note/bug This PR fixes an issue in a previous release of Cilium. and removed kind/bug This is a bug in the Cilium logic. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Feb 20, 2026
@MrFreezeex
Copy link
Copy Markdown
Member Author

/test

@MrFreezeex MrFreezeex added affects/v1.17 This issue affects v1.17 branch affects/v1.18 This issue affects v1.18 branch affects/v1.19 This issue affects v1.19 branch labels Feb 20, 2026
Copy link
Copy Markdown
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Copy Markdown
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 23, 2026
@gandro gandro added this pull request to the merge queue Feb 23, 2026
Merged via the queue into main with commit 4d5b227 Feb 23, 2026
495 of 498 checks passed
@gandro gandro deleted the pr/mrfreezeex/mcs-api-ownerrefperm branch February 23, 2026 09:04
@YutaroHayakawa YutaroHayakawa mentioned this pull request Feb 24, 2026
21 tasks
@YutaroHayakawa YutaroHayakawa added backport-pending/1.19 The backport for Cilium 1.19.x for this PR is in progress. and removed needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch labels Feb 24, 2026
@github-actions github-actions bot added backport-done/1.19 The backport for Cilium 1.19.x for this PR is done. and removed backport-pending/1.19 The backport for Cilium 1.19.x for this PR is in progress. labels Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

affects/v1.17 This issue affects v1.17 branch affects/v1.18 This issue affects v1.18 branch affects/v1.19 This issue affects v1.19 branch area/clustermesh Relates to multi-cluster routing functionality in Cilium. area/helm Impacts helm charts and user deployment experience backport-done/1.19 The backport for Cilium 1.19.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants