clustermesh: fix a goroutine leak in epslicesync#44444
Merged
giorio94 merged 1 commit intocilium:mainfrom Feb 23, 2026
Merged
Conversation
Member
Author
|
/test |
051f725 to
9a3a2da
Compare
Member
Author
|
/test |
Member
Author
|
So the error doesn't appear anymore while using the stress command but there seems to be something else failing there on very rare occasion (~0.12% locally). But at least I don't get the goroutine leaks anymore, so this should be fine on its own and I will check the other failure later on 👀 |
The receive function could stall because of the send to the unbuffered result channel and prevent the goroutine from terminating. This commit fixes that by following the same approach as StreamWatcher (which the meshEndpointSliceWatcher is inspired from) to avoid this leak. Reported-by: Tobias Klauser <tobias@cilium.io> Signed-off-by: Arthur Outhenin-Chalandre <git@mrfreezeex.fr>
9a3a2da to
f7f0ac5
Compare
Member
Author
|
/test |
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The receive function could stall because of the send to the unbuffered result channel and prevent the goroutine from terminating. This commit fixes that by following the same approach as StreamWatcher (which the meshEndpointSliceWatcher is inspired from) to avoid this leak.
Fixes #44421