clustermesh: remove hostAliases and replace it by a custom dialer#44425
Merged
MrFreezeex merged 4 commits intomainfrom Mar 2, 2026
Merged
clustermesh: remove hostAliases and replace it by a custom dialer#44425MrFreezeex merged 4 commits intomainfrom
MrFreezeex merged 4 commits intomainfrom
Conversation
Member
Author
|
/test |
2c316ea to
9f6f6ca
Compare
Member
Author
|
/test |
1 similar comment
Member
Author
|
/test |
Member
Author
|
This PR is the continuation from this PR to test the small workflow change in a cilium/cilium branch instead of a fork: #43767 (sorry again to the existing reviewers :/). |
aanm
approved these changes
Feb 19, 2026
giorio94
approved these changes
Feb 24, 2026
Member
giorio94
left a comment
There was a problem hiding this comment.
Thanks! Changes look good to me, except for an inline suggestion around the format of the user-facing configuration.
christarazi
approved these changes
Feb 24, 2026
asauber
approved these changes
Feb 25, 2026
32bc223 to
6d8d8a6
Compare
Member
Author
|
/test |
6d8d8a6 to
cdeedc7
Compare
This commit add a Cilium config struct parsed from the etcd config to connect to each remote clustermesh-apiserver. These fields are ignored by etcd which ignore any unknown fields (like most go program do) and will be used in a future commit to replace the host aliases on Pods which forces restarts when changed. Signed-off-by: Arthur Outhenin-Chalandre <git@mrfreezeex.fr>
Add a new static dialier and wire it in the clustermesh code with the config that was added in the previous commit. This new static dialer attempt to be very close to the net.Dialer with very similar code and partially the same behavior (it has to be a bit different since we don't resolve anything though). It will fallback to another dialer so that we can just chain dialer like the one we are already using. This dialer will attempt every IPs and if the context has a deadline set it will have partial distribution logic which essentially boils down to dividing the remaining deadline from the original context with the number of remaining IPs to attempt connection to. This logic is directly taken from the net.Dialer logic. Note that to my knowledge we don't have any deadline set in the ClusterMesh code though. Signed-off-by: Arthur Outhenin-Chalandre <git@mrfreezeex.fr>
Add the cilium-host-aliases in the etcd config which should be fully replacing hostaliases in Cilium 1.21. We are keeping hostAliases for now to keep downgrade safe (secrets updated without cilium-clustermesh-apiserver-host and potentially without hostAliases if we were already removing it here). We are force disabling this in the conformance ClusterMesh CI via a non documented helm values to already exercise that this is working properly while the conformance upgrade CI stays on default setting to keep the existing flow tested! Signed-off-by: Arthur Outhenin-Chalandre <git@mrfreezeex.fr>
Previous commits added a new static dialer in order to replace hostAliases. This commit now wires this new static dialer to the clustermesh troubleshoot command. Signed-off-by: Arthur Outhenin-Chalandre <git@mrfreezeex.fr>
Member
Author
|
(rebasing below this comment) |
cdeedc7 to
38520ab
Compare
Member
Author
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See each commit
Fixes #42716