Skip to content

clustermesh: ci: add MCS-API conformance test#44424

Merged
MrFreezeex merged 2 commits intomainfrom
pr/mrfreezeex/mcs-api-conformance
Mar 3, 2026
Merged

clustermesh: ci: add MCS-API conformance test#44424
MrFreezeex merged 2 commits intomainfrom
pr/mrfreezeex/mcs-api-conformance

Conversation

@MrFreezeex
Copy link
Copy Markdown
Member

@MrFreezeex MrFreezeex commented Feb 18, 2026 •
edited
Loading 

clustermesh: run official MCS-API conformance in CI

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 18, 2026
@MrFreezeex MrFreezeex added area/CI Continuous Integration testing issue or flake release-note/minor This PR changes functionality that users may find relevant to operating Cilium. area/clustermesh Relates to multi-cluster routing functionality in Cilium. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Feb 18, 2026
@MrFreezeex MrFreezeex force-pushed the pr/mrfreezeex/mcs-api-conformance branch 3 times, most recently from 0db0f1d to 39acc6f Compare February 18, 2026 15:26
@MrFreezeex
Copy link
Copy Markdown
Member Author

MrFreezeex commented Feb 18, 2026

/ci-mcs-api

@MrFreezeex MrFreezeex force-pushed the pr/mrfreezeex/mcs-api-conformance branch from 39acc6f to a1a4177 Compare February 18, 2026 15:49
@MrFreezeex
Copy link
Copy Markdown
Member Author

MrFreezeex commented Feb 18, 2026

/test

@MrFreezeex MrFreezeex force-pushed the pr/mrfreezeex/mcs-api-conformance branch from a1a4177 to 85c82f1 Compare February 19, 2026 10:46
@MrFreezeex
Copy link
Copy Markdown
Member Author

MrFreezeex commented Feb 19, 2026

/test

@MrFreezeex MrFreezeex force-pushed the pr/mrfreezeex/mcs-api-conformance branch 8 times, most recently from 9ea10d8 to 30f414e Compare February 25, 2026 18:58
@MrFreezeex MrFreezeex marked this pull request as ready for review February 25, 2026 18:59
@MrFreezeex MrFreezeex requested review from a team as code owners February 25, 2026 18:59
@MrFreezeex MrFreezeex removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Mar 2, 2026
@viktor-kurchenko
Copy link
Copy Markdown
Contributor

viktor-kurchenko commented Mar 2, 2026

/test

@viktor-kurchenko
Copy link
Copy Markdown
Contributor

viktor-kurchenko commented Mar 2, 2026

@MrFreezeex thank you for the contribution!

A couple of clarifications:

  1. Could you please add a bit of description to commit messages?
  2. The last commit has wip: prefix. Are you going to add something there?

@MrFreezeex MrFreezeex force-pushed the pr/mrfreezeex/mcs-api-conformance branch from 441677b to 96b9567 Compare March 2, 2026 18:22
@MrFreezeex
Copy link
Copy Markdown
Member Author

MrFreezeex commented Mar 2, 2026

Hi @viktor-kurchenko,

Could you please add a bit of description to commit messages?

Sure! I added a few details in those in my last push

The last commit has wip: prefix. Are you going to add something there?

Not really it was the way I found to actually trigger this test as I think I can't trigger it via ariane if some combination of ariane config / workflow are not in main (I think?), I am going to drop this before merging the PR essentially as I was also saying here: #44424 (comment)

@viktor-kurchenko
Copy link
Copy Markdown
Contributor

viktor-kurchenko commented Mar 2, 2026

Sure! I added a few details in those in my last push

Thank you!

Not really it was the way I found to actually trigger this test as I think I can't trigger it via ariane if some combination of ariane config / workflow are not in main (I think?), I am going to drop this before merging the PR essentially as I was also saying here: #44424 (comment)

Gotcha!

@viktor-kurchenko
Copy link
Copy Markdown
Contributor

viktor-kurchenko commented Mar 2, 2026

/test

viktor-kurchenko
viktor-kurchenko approved these changes Mar 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@viktor-kurchenko viktor-kurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrFreezeex
clustermesh: integrate mcs-api conformance test
557cf73 
Wire up MCS-API official conformance test in our go test infra. The
approach done here is the same/is copied from the existing Gateway-API
conformance test and essentially done through direct go dependency
rather than building the test separately.

Signed-off-by: Arthur Outhenin-Chalandre <git@mrfreezeex.fr>
@MrFreezeex
ci: add workflow to trigger MCS-API conformance
83e7646 
Add a new workflow to trigger the MCS-API conformance test added in the
previous commit. This new workflow is essentially a crossover of the
existing conformance clustermesh workflow and the Gateway-API workflow
(as we based the go test integration of MCS-API on the existing
Gateway-API ones).

This new workflow keep a matrix shape for future extensibility and
remain close to the other clustermesh/gateway-api workflows.

Signed-off-by: Arthur Outhenin-Chalandre <git@mrfreezeex.fr>
@MrFreezeex MrFreezeex force-pushed the pr/mrfreezeex/mcs-api-conformance branch from 96b9567 to 83e7646 Compare March 3, 2026 17:29
@MrFreezeex
Copy link
Copy Markdown
Member Author

MrFreezeex commented Mar 3, 2026

/test

@MrFreezeex MrFreezeex enabled auto-merge March 3, 2026 17:29
@cilium-ariane
Copy link
Copy Markdown

cilium-ariane bot commented Mar 3, 2026

/test

@MrFreezeex MrFreezeex added this pull request to the merge queue Mar 3, 2026
Merged via the queue into main with commit 065c45c Mar 3, 2026
682 of 687 checks passed
@MrFreezeex MrFreezeex deleted the pr/mrfreezeex/mcs-api-conformance branch March 3, 2026 20:55
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Mar 3, 2026
@joestringer joestringer added release-note/ci This PR makes changes to the CI. and removed release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Apr 1, 2026
@joestringer
Copy link
Copy Markdown
Member

joestringer commented Apr 1, 2026

@MrFreezeex just FYI I changed the release note for this one to CI, as there's no user-facing changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nebril nebril nebril approved these changes

@bimmlerd bimmlerd bimmlerd approved these changes

@HadrienPatte HadrienPatte HadrienPatte approved these changes

@thorn3r thorn3r thorn3r approved these changes

@viktor-kurchenko viktor-kurchenko viktor-kurchenko approved these changes

Assignees

No one assigned

Labels

area/CI Continuous Integration testing issue or flake area/clustermesh Relates to multi-cluster routing functionality in Cilium. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@MrFreezeex @viktor-kurchenko @joestringer @nebril @bimmlerd @HadrienPatte @thorn3r