docs: fix duplicate --version in Helm OCI examples#44380
Merged
qmonnet merged 1 commit intocilium:mainfrom Feb 16, 2026
Merged
Conversation
|CHART_VERSION| already expands to '--version <release>'. Removing the extra literal --version before |CHART_VERSION| so the rendered CLI is correct (e.g. single '--version 1.19.0'). Signed-off-by: Ghassan Malke <ghassan+github@malke.nl>
Contributor
Author
|
The dont-merge/... label was added by mistake, this PR is ready for review. Could someone remove that label? Thanks! |
Member
This was not a mistake, this was simply because the PR needed someone with sufficient permissions to add the relevant |
Member
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.
Description:
In the stable docs,
|CHART_VERSION|is substituted with--version <release>(e.g.--version 1.19.0). The Helm OCI examples had an extra literal--versionbefore|CHART_VERSION|, which produced a duplicate flag in the rendered output (e.g.--version --version 1.19.0).