k8s/watchers: call UpdateBandwidthPolicy when priority annotation change#44329
Merged
julianwiedmann merged 1 commit intocilium:mainfrom Feb 18, 2026
Merged
Conversation
8 tasks
YutaroHayakawa
approved these changes
Feb 13, 2026
Contributor
Author
|
@YutaroHayakawa Hi， Thanks for your review, will someone else help to merge and backport this to 1.19? |
…nges When only the bandwidth.Priority annotation changes (without EgressBandwidth/IngressBandwidth changing), UpdateBandwidthPolicy was not being called, preventing the priority update from taking effect. Fixes the condition to also trigger on annoChangedPriority. Signed-off-by: zbb88888 <jmdxjsjgcxy@gmail.com>
9ac7fa2 to
405771c
Compare
Member
|
What you need to do is labelling with needs-backport label. Usually, you need to check whether your change is eligible for backporting with this backport criteria. In this case, this is a bug fix and we are targeting v1.19 (the current minor release), so all bug fixes should be there, so we are good. I already put the label. |
Member
|
Also please fill the release-note section in the PR description from next time. That helps understanding what kind of the bug fix you made in the release note. |
Member
|
/test |
Contributor
Author
|
@YutaroHayakawa Hi, thanks for your review, I have edit the PR description. |
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When only the bandwidth.Priority annotation changes (without EgressBandwidth/IngressBandwidth changing), UpdateBandwidthPolicy was not being called, preventing the priority update from taking effect.
Fixes the condition to also trigger on annoChangedPriority.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.
Fixes: #issue-number