*: make dumps retry in netlink library, remove safenetlink package#44315
Draft
ti-mo wants to merge 4 commits intocilium:mainfrom
Draft
*: make dumps retry in netlink library, remove safenetlink package#44315ti-mo wants to merge 4 commits intocilium:mainfrom
ti-mo wants to merge 4 commits intocilium:mainfrom
Conversation
Contributor
Author
|
/test |
6472ff7 to
2bbb391
Compare
Contributor
Author
|
/test |
1 similar comment
Contributor
Author
|
/test |
2bbb391 to
918b98f
Compare
Contributor
Author
|
/test |
918b98f to
1761ce4
Compare
Contributor
Author
|
/test |
1761ce4 to
8c3036f
Compare
Contributor
Author
|
/test |
1 similar comment
Contributor
Author
|
/test |
8c3036f to
e6f9dc8
Compare
Contributor
Author
|
/test |
1 similar comment
Contributor
Author
|
/test |
e6f9dc8 to
da3e477
Compare
Contributor
Author
|
/test |
1 similar comment
|
/test |
1e528d2 to
7690639
Compare
Contributor
Author
|
/test |
1 similar comment
|
/test |
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
7690639 to
2ea87df
Compare
Contributor
Author
|
/test |
|
/test |
This commit removes package safenetlink, and adds a small wrapper package for netlink.NewHandle that takes care of setting defaults. The forbidigo config is update to enforce usage of inl.NewHandle() over netlink.NewHandle(). Lastly, add a testutils/inl subpackage with a NetNSHandle function for easy Handle creation in tests. Signed-off-by: Timo Beckers <timo@isovalent.com>
In order to enable the new implicit retry behaviour across the board, the global netlink handle needs to be configured to do so. This is done as a side effect of importing package inl. Configure the handle in: - cilium-agent - cilium-dbg - cilium-cni - bugtool Signed-off-by: Timo Beckers <timo@isovalent.com>
2ea87df to
76257c8
Compare
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just trying out whether this works, but will send this upstream if it does.