Skip to content

clustermesh: fix a few misc issue with MCS-API doc#44299

Merged
joestringer merged 1 commit intocilium:mainfrom
MrFreezeex:mcs-doc-typo-fix
Feb 11, 2026
Merged

clustermesh: fix a few misc issue with MCS-API doc#44299
joestringer merged 1 commit intocilium:mainfrom
MrFreezeex:mcs-doc-typo-fix

Conversation

@MrFreezeex
Copy link
Copy Markdown
Member

@MrFreezeex MrFreezeex commented Feb 11, 2026 •
edited
Loading

This commit fixes two issue with mcs-api doc:

  • a simple typo on the enabled keyword
  • change the code-block in parsed-literal as the |SCM_WEB| "variable" was not evaluated/replaced in the final doc with a code-block
clustermesh: fix a few minor typo/issues in the MCS-API documentation

@MrFreezeex
clustermesh: fix a few misc issue with MCS-API doc
19cf209 
This commit fixes two issue with mcs-api doc:
- a simple typo on the enabled keywork
- change the code-block in parsed-literal as the |SCM_WEB| "variable"
  was not evaluated/replaced in the final doc with a code-block

Signed-off-by: Arthur Outhenin-Chalandre <git@mrfreezeex.fr>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 11, 2026
@MrFreezeex MrFreezeex added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/bug This PR fixes an issue in a previous release of Cilium. area/clustermesh Relates to multi-cluster routing functionality in Cilium. needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Feb 11, 2026
@MrFreezeex
Copy link
Copy Markdown
Member Author

MrFreezeex commented Feb 11, 2026 •
edited
Loading

Looks like the |SCM_WEB| does work fine now 🎉.

netlify url / after this fix: https://deploy-preview-44299--docs-cilium-io.netlify.app/network/clustermesh/mcsapi#prerequisites
before / current stable doc: https://docs.cilium.io/en/latest/network/clustermesh/mcsapi/#prerequisites

@MrFreezeex
Copy link
Copy Markdown
Member Author

MrFreezeex commented Feb 11, 2026

/test

@MrFreezeex MrFreezeex marked this pull request as ready for review February 11, 2026 12:04
@MrFreezeex MrFreezeex requested review from a team as code owners February 11, 2026 12:04
joestringer
joestringer approved these changes Feb 11, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catches, thanks.

@joestringer joestringer added this pull request to the merge queue Feb 11, 2026
Merged via the queue into cilium:main with commit 94a64cb Feb 11, 2026
83 checks passed
@glrf glrf mentioned this pull request Feb 17, 2026
Merged
12 tasks
@glrf glrf added backport-pending/1.19 The backport for Cilium 1.19.x for this PR is in progress. and removed needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch labels Feb 17, 2026
@github-actions github-actions bot added backport-done/1.19 The backport for Cilium 1.19.x for this PR is done. and removed backport-pending/1.19 The backport for Cilium 1.19.x for this PR is in progress. labels Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joestringer joestringer joestringer approved these changes

@thorn3r thorn3r Awaiting requested review from thorn3r thorn3r is a code owner automatically assigned from cilium/sig-clustermesh

Assignees

No one assigned

Labels

area/clustermesh Relates to multi-cluster routing functionality in Cilium. area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.19 The backport for Cilium 1.19.x for this PR is done. release-note/bug This PR fixes an issue in a previous release of Cilium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MrFreezeex @joestringer @glrf