golangci-lint: make .golangci.yaml compatible again with non-custom build#44295
Merged
ti-mo merged 2 commits intocilium:mainfrom Feb 13, 2026
Merged
golangci-lint: make .golangci.yaml compatible again with non-custom build#44295ti-mo merged 2 commits intocilium:mainfrom
ti-mo merged 2 commits intocilium:mainfrom
Conversation
golangci-lint.sh would always rebuild the binary. The script was over-engineered and didn't use the `golangci-lint version` subcommand, which doesn't need the version string parsing logic. Simplify the script and fix the rebuild trigger. Prepare the directory structure for splitting the main .golangci-lint.yaml in a subsequent commit. Signed-off-by: Timo Beckers <timo@isovalent.com>
The addition of kubeapilinter forced all users of the main .golangci.yaml to be running a custom-built version of the tool and make sure it's kept in sync. VSCode runs `golangci-lint run` in the repo by default and requires explicit configuration to use another tool, like a script in the Cilium repository. Before this PR, the script was broken and would always rebuilt custom-gcl. Breaking the default tooling is not great. This commit moves kubeapi-specific configuration to a dedicated config file in tools/golangci-lint-kubeapi and specifies it explicitly when starting the kubeapi linter. Signed-off-by: Timo Beckers <timo@isovalent.com>
Contributor
Author
|
/test |
tommyp1ckles
approved these changes
Feb 12, 2026
bimmlerd
approved these changes
Feb 12, 2026
Member
bimmlerd
left a comment
There was a problem hiding this comment.
I don't have a huge amount of context on this change, but changes look sensible to me.
christarazi
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
golangci-lint runin repo root works again with a default install (e.g. from distro package manager or Docker image)-tiarguments to the Dockerized makefile target to make it obey ^C