Skip to content

docs(ztunnel): fix some typo#44294

Merged
joestringer merged 2 commits intocilium:mainfrom
alagoutte:doc-ztunnel-typo
Feb 11, 2026
Merged

docs(ztunnel): fix some typo#44294
joestringer merged 2 commits intocilium:mainfrom
alagoutte:doc-ztunnel-typo

Conversation

@alagoutte
Copy link
Copy Markdown
Contributor

@alagoutte alagoutte commented Feb 11, 2026

fix some typo found after review ztunnel docs

may be also prefer cilium helm install ? (set before cilium cli)

and move bash script on cilium repo ?

@alagoutte
docs(ztunnel): fix duplicate word (a set)
87ef63a 
Signed-off-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
@alagoutte
docs(ztunnel): add missing backslash
65d4414 
add missing backslash for install with Cilium CLI

Signed-off-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
@alagoutte alagoutte requested review from a team as code owners February 11, 2026 06:52
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 11, 2026
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Feb 11, 2026
@joestringer joestringer added release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch labels Feb 11, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Feb 11, 2026
joestringer
joestringer approved these changes Feb 11, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fixes 🙏

@joestringer joestringer reopened this Feb 11, 2026
@joestringer
Copy link
Copy Markdown
Member

joestringer commented Feb 11, 2026

/test

@joestringer
Copy link
Copy Markdown
Member

joestringer commented Feb 11, 2026

and move bash script on cilium repo ?

Do you have a concrete proposal? You could send another PR. The file is already at examples/kubernetes-ztunnel/generate-secrets.sh.

@joestringer joestringer added this pull request to the merge queue Feb 11, 2026
Merged via the queue into cilium:main with commit cd97578 Feb 11, 2026
135 of 137 checks passed
@alagoutte
Copy link
Copy Markdown
Contributor Author

alagoutte commented Feb 11, 2026

LGTM, thanks for the fixes 🙏

Thanks, it is possible to backport to stable ? too

@alagoutte
Copy link
Copy Markdown
Contributor Author

alagoutte commented Feb 11, 2026

and move bash script on cilium repo ?

Do you have a concrete proposal? You could send another PR. The file is already at examples/kubernetes-ztunnel/generate-secrets.sh.

Yes, add only a link to the file and example of output, it will make a PR for this

@joestringer
Copy link
Copy Markdown
Member

joestringer commented Feb 11, 2026

Thanks, it is possible to backport to stable ? too

I've added the labels to request backport. The update should hit /v1.19 after the backport is prepared and merged, then /stable should display the change by around mid-March.

@alagoutte
Copy link
Copy Markdown
Contributor Author

alagoutte commented Feb 11, 2026 •
edited
Loading

oups missing the /1.19 label

Thanks !

@glrf glrf mentioned this pull request Feb 17, 2026
Merged
12 tasks
@glrf glrf added backport-pending/1.19 The backport for Cilium 1.19.x for this PR is in progress. and removed needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch labels Feb 17, 2026
@github-actions github-actions bot added backport-done/1.19 The backport for Cilium 1.19.x for this PR is done. and removed backport-pending/1.19 The backport for Cilium 1.19.x for this PR is in progress. labels Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joestringer joestringer joestringer approved these changes

@ldelossa ldelossa Awaiting requested review from ldelossa ldelossa is a code owner automatically assigned from cilium/ztunnel

Assignees

No one assigned

Labels

backport-done/1.19 The backport for Cilium 1.19.x for this PR is done. kind/community-contribution This was a contribution made by a community member. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alagoutte @joestringer @glrf