bpf: remove bpf_network.c and associated agent code#44284
Merged
ti-mo merged 2 commits intocilium:mainfrom Feb 26, 2026
Merged
Conversation
Contributor
Author
|
/test |
smagnani96
reviewed
Feb 10, 2026
smagnani96
reviewed
Feb 10, 2026
Contributor
smagnani96
left a comment
There was a problem hiding this comment.
First pass LGTM, left a comment.
Ping me again when you've looked at --encrypt-interface 💯
f6d8428 to
625c3b6
Compare
Contributor
Author
|
/test |
smagnani96
reviewed
Feb 10, 2026
625c3b6 to
444bf6b
Compare
Contributor
Author
|
/test |
444bf6b to
26a7233
Compare
Contributor
Author
|
/test |
26a7233 to
c0533a6
Compare
Contributor
Author
|
/test |
smagnani96
approved these changes
Feb 11, 2026
Contributor
smagnani96
left a comment
There was a problem hiding this comment.
LGTM, nothing else from my side 🙏🏼
You'll have to ping me again when undrafting this I guess (:github-intensifies:).
5557bed to
79c80a7
Compare
Contributor
Author
|
/test |
aanm
approved these changes
Feb 12, 2026
christarazi
approved these changes
Feb 13, 2026
asauber
approved these changes
Feb 13, 2026
dylandreimerink
approved these changes
Feb 16, 2026
79c80a7 to
daff2d8
Compare
Contributor
Author
|
/test |
smagnani96
approved these changes
Feb 18, 2026
Since commit a8c19d8 ("ipsec,config: require devices when IPsec is enabled"), shipped in Cilium 1.18, bpf_network.c quietly became dead code due to the introduction of a tautological condition: ``` if !lnc.EnableIPSec || option.Config.AreDevicesRequired(..., lnc.EnableIPSec) { return nil } ``` AreDevicesRequired returns true if lnc.EnableIPSec is true, turning this into: ``` if !lnc.EnableIPSec || lnc.EnableIPSec { return nil } ``` This commit removed bpf_network.c, its tests, loader code and some cleanup routines. Signed-off-by: Timo Beckers <timo@isovalent.com>
…face` This has been defunct since Cilium 1.18 and ignored since the previous commit. Signed-off-by: Timo Beckers <timo@isovalent.com>
daff2d8 to
119b14d
Compare
Contributor
Author
|
/test |
rolinh
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since commit a8c19d8 ("ipsec,config: require devices when IPsec is enabled"), shipped in Cilium 1.18, bpf_network.c quietly became dead code due to the introduction of a tautological condition:
AreDevicesRequired returns true if lnc.EnableIPSec is true, turning this into:
This PR removes the Helm value, bpf_network.c, its tests, loader code and some cleanup routines.