Skip to content

.github/workflows: eks-cluster-pool-manager: fix race condition and c…#44283

Merged
aanm merged 1 commit intomainfrom
pr/fix-eks-cluster-creation
Feb 10, 2026
Merged

.github/workflows: eks-cluster-pool-manager: fix race condition and c…#44283
aanm merged 1 commit intomainfrom
pr/fix-eks-cluster-creation

Conversation

@aanm
Copy link
Copy Markdown
Member

@aanm aanm commented Feb 10, 2026

…leanup leaked IAM roles

When multiple parallel jobs generate cluster names within the same second, they can produce identical names since the timestamp has only 1-second precision. This causes CloudFormation stack creation to fail with "AlreadyExistsException", leaving orphaned IAM roles behind.

This commit adds a random suffix to cluster names to prevent race conditions and enhances the failure cleanup step to delete CloudFormation stacks and orphaned IAM roles when cluster creation fails

…leanup leaked IAM roles

When multiple parallel jobs generate cluster names within the same
second, they can produce identical names since the timestamp has only
1-second precision. This causes CloudFormation stack creation to fail
with "AlreadyExistsException", leaving orphaned IAM roles behind.

This commit adds a random suffix to cluster names to prevent race conditions
and enhances the failure cleanup step to delete CloudFormation stacks and orphaned
IAM roles when cluster creation fails

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm requested review from a team as code owners February 10, 2026 14:35
@aanm aanm added kind/bug/CI This is a bug in the testing code. release-note/ci This PR makes changes to the CI. labels Feb 10, 2026
@aanm aanm requested a review from nbusseneau February 10, 2026 14:35
@aanm aanm added the needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch label Feb 10, 2026
@aanm
Copy link
Copy Markdown
Member Author

aanm commented Feb 10, 2026

/test

@aanm aanm enabled auto-merge February 10, 2026 14:35
@aanm aanm added this pull request to the merge queue Feb 10, 2026
Merged via the queue into main with commit 98aeae6 Feb 10, 2026
82 of 84 checks passed
@aanm aanm deleted the pr/fix-eks-cluster-creation branch February 10, 2026 15:22
@glrf glrf mentioned this pull request Feb 17, 2026
12 tasks
@glrf glrf added backport-pending/1.19 The backport for Cilium 1.19.x for this PR is in progress. and removed needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch labels Feb 17, 2026
@github-actions github-actions bot added backport-done/1.19 The backport for Cilium 1.19.x for this PR is done. and removed backport-pending/1.19 The backport for Cilium 1.19.x for this PR is in progress. labels Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-done/1.19 The backport for Cilium 1.19.x for this PR is done. kind/bug/CI This is a bug in the testing code. release-note/ci This PR makes changes to the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants