Skip to content

test/helpers: ignore error creating lease lock message#44282

Merged
aanm merged 1 commit intomainfrom
pr/fix-ginkgo-test
Feb 10, 2026
Merged

test/helpers: ignore error creating lease lock message#44282
aanm merged 1 commit intomainfrom
pr/fix-ginkgo-test

Conversation

@aanm
Copy link
Copy Markdown
Member

@aanm aanm commented Feb 10, 2026

This message was modified in k8s 1.35.0, therefore we should update the list of messages that can be ignored in our CI.

Fixes #44082

This message was modified in k8s 1.35.0, therefore we should update the
list of messages that can be ignored in our CI.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added kind/bug/CI This is a bug in the testing code. release-note/ci This PR makes changes to the CI. needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch labels Feb 10, 2026
@aanm
Copy link
Copy Markdown
Member Author

aanm commented Feb 10, 2026

/test

@aanm aanm marked this pull request as ready for review February 10, 2026 13:33
@aanm aanm requested a review from a team as a code owner February 10, 2026 13:33
@aanm aanm requested a review from christarazi February 10, 2026 13:33
Copy link
Copy Markdown
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add the message to the ignore list for cilium-cli connectivity tests in cilium-cli/connectivity/tests/errors.go as well? Or do we expect these messages to not occur for these tests?

@aanm aanm enabled auto-merge February 10, 2026 14:47
@aanm
Copy link
Copy Markdown
Member Author

aanm commented Feb 10, 2026

Should we add the message to the ignore list for cilium-cli connectivity tests in cilium-cli/connectivity/tests/errors.go as well? Or do we expect these messages to not occur for these tests?

Good question, I don't see the "older" error in there so I assume it does not occur in the cli tests.

@aanm aanm added this pull request to the merge queue Feb 10, 2026
Merged via the queue into main with commit fbabd89 Feb 10, 2026
152 checks passed
@aanm aanm deleted the pr/fix-ginkgo-test branch February 10, 2026 17:32
@glrf glrf mentioned this pull request Feb 17, 2026
12 tasks
@glrf glrf added backport-pending/1.19 The backport for Cilium 1.19.x for this PR is in progress. and removed needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch labels Feb 17, 2026
@github-actions github-actions bot added backport-done/1.19 The backport for Cilium 1.19.x for this PR is done. and removed backport-pending/1.19 The backport for Cilium 1.19.x for this PR is in progress. labels Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-done/1.19 The backport for Cilium 1.19.x for this PR is done. kind/bug/CI This is a bug in the testing code. release-note/ci This PR makes changes to the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: Conformance Ginkgo: cilium-operator-resource-lock already exists

5 participants