Skip to content

test: remove K8sDatapathBandwidthTest#44226

Merged
pchaigno merged 1 commit intocilium:mainfrom
puwun:ci/rm-bandwidth-test
Feb 12, 2026
Merged

test: remove K8sDatapathBandwidthTest#44226
pchaigno merged 1 commit intocilium:mainfrom
puwun:ci/rm-bandwidth-test

Conversation

@puwun
Copy link
Copy Markdown
Contributor

@puwun puwun commented Feb 6, 2026 •
edited
Loading

Changes:

  • Deleted test/k8s/bandwidth.go
  • Removed test references from .github/actions/ginkgo/main-focus.yaml
  • Removed test mapping from test/ginkgo-ext/junit_reporter.go
  • Removed stale entry from CODEOWNERS

Fixes: #44165
Related: #37837

@puwun puwun requested review from a team as code owners February 6, 2026 11:42
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 6, 2026
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Feb 6, 2026
@puwun puwun force-pushed the ci/rm-bandwidth-test branch from 2786d84 to 07db665 Compare February 6, 2026 11:49
@puwun puwun requested a review from a team as a code owner February 6, 2026 11:49
@puwun puwun requested a review from tklauser February 6, 2026 11:49
@joestringer
Copy link
Copy Markdown
Member

joestringer commented Feb 6, 2026

Where is this functionality being tested if it's not tested in the K8sDatapathBandwidthTest?

@joestringer joestringer added the release-note/ci This PR makes changes to the CI. label Feb 6, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 6, 2026
@puwun
Copy link
Copy Markdown
Contributor Author

puwun commented Feb 7, 2026

it's in cilium-cli/connectivity/builder/network_bandwidth_limit.go

cilium/cilium-cli/connectivity/builder/network_bandwidth_limit.go

Lines 13 to 17 in 74c333d

func (t networkBandwidthLimit) build(ct *check.ConnectivityTest, _ map[string]string) {
newTest("network-bandwidth-limit", ct).
WithCondition(func() bool { return ct.Params().Perf }).
WithScenarios(netperf.NetBandwidth(""))
}

@joestringer
Copy link
Copy Markdown
Member

joestringer commented Feb 10, 2026

I see, thanks for pointing that out. Can you describe how you made sure that these changes won't reduce coverage over the feature?

@puwun
Copy link
Copy Markdown
Contributor Author

puwun commented Feb 11, 2026

The Ginkgo bandwidth test was already not running in CI. It only ran on net-next kernels, but the focus group that included it was excluded from the net-next job

exclude:
  # The bandwidth test is disabled and hubble tests are not meant
  # to run on net-next.
  - k8s-version: "1.35"
    focus: "f10-agent-hubble-bandwidth"

basically it never ran anywhere, so what I did was just removed the dead code

pchaigno
pchaigno reviewed Feb 11, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you repeat in the commit description the additional context you gave in response to Joe's question? Other than that, looks good to me.

@puwun
test: remove K8sDatapathBandwidthTest
d810de5 
The Ginkgo bandwidth test was already not running in CI. It only ran on
net-next kernels, but the focus group that included it
(f10-agent-hubble-bandwidth) was excluded from the net-next job.
Bandwidth enforcement is independently tested in
cilium-cli/connectivity/builder/network_bandwidth_limit.go.

Fixes: cilium#44165
Related: cilium#37837
Signed-off-by: Pavan More <pavansmore05@gmail.com>
@puwun puwun force-pushed the ci/rm-bandwidth-test branch from 07db665 to d810de5 Compare February 11, 2026 15:05
pchaigno
pchaigno approved these changes Feb 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@pchaigno
Copy link
Copy Markdown
Member

pchaigno commented Feb 12, 2026

/test

@pchaigno pchaigno enabled auto-merge February 12, 2026 07:34
@pchaigno pchaigno added this pull request to the merge queue Feb 12, 2026
Merged via the queue into cilium:main with commit 437573b Feb 12, 2026
76 of 77 checks passed
@nXtCyberNet nXtCyberNet mentioned this pull request Mar 23, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tklauser tklauser tklauser approved these changes

@pchaigno pchaigno pchaigno approved these changes

@Artyop Artyop Artyop approved these changes

@dylandreimerink dylandreimerink Awaiting requested review from dylandreimerink dylandreimerink was automatically assigned from cilium/sig-datapath

Assignees

No one assigned

Labels

kind/community-contribution This was a contribution made by a community member. release-note/ci This PR makes changes to the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate K8sDatapathBandwidthTest to newer testing infrastructure

5 participants

@puwun @joestringer @pchaigno @tklauser @Artyop