helm: allow multicluster-services installCRDs to update CRDs#44224
Merged
MrFreezeex merged 1 commit intocilium:mainfrom Feb 6, 2026
Merged
helm: allow multicluster-services installCRDs to update CRDs#44224MrFreezeex merged 1 commit intocilium:mainfrom
MrFreezeex merged 1 commit intocilium:mainfrom
Conversation
Previously cilium-operator fails to start if MCS/installCRDs is enabled because it does not have permissions to update the CRD with this log message: level=error msg="Unable to update CRD" module=operator.operator-controlplane.leader-lifecycle.create-crds name=serviceimports.multicluster.x-k8s.io error="customresourcedefinitions.apiextensions.k8s.io \"serviceimports.multicluster.x-k8s.io\" is forbidden: User \"system:serviceaccount:kube-system:cilium-operator\" cannot update resource \"customresourcedefinitions\" in API group \"apiextensions.k8s.io\" at the cluster scope" This patch adds the necessary permissions to cilium-operator if you have mcs/installCRDs enabled Fixes: cilium#44210 Fixes: 3874013 ("clustermesh: add config for auto installing MCS-API CRDs") Signed-off-by: Florian Ströger <stroeger@youniqx.com>
Member
|
/test |
MrFreezeex
approved these changes
Feb 6, 2026
Member
MrFreezeex
left a comment
There was a problem hiding this comment.
Thank you so much for the bug report and fixing this! This looks perfect 🙏
Artyop
approved these changes
Feb 6, 2026
Contributor
|
/test |
Contributor
Author
Absolutely. Thanks for making the MCS integration in the first place. I think its really cool. |
Contributor
Author
|
is the |
Member
I am not entirely sure TBH but it's marked as not required so it probably is a bit flaky indeed 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.
No permissions, its (@MrFreezeex)
Previously cilium-operator fails to start if MCS/installCRDs is enabled because it does not have permissions to update the CRD with this log message:
level=error msg="Unable to update CRD" module=operator.operator-controlplane.leader-lifecycle.create-crds name=serviceimports.multicluster.x-k8s.io error="customresourcedefinitions.apiextensions.k8s.io \"serviceimports.multicluster.x-k8s.io\" is forbidden: User \"system:serviceaccount:kube-system:cilium-operator\" cannot update resource \"customresourcedefinitions\" in API group \"apiextensions.k8s.io\" at the cluster scope"This patch adds the necessary permissions to cilium-operator if you have mcs/installCRDs enabled
Fixes: #44210
Fixes: 3874013 ("clustermesh: add config for auto installing MCS-API CRDs")