Skip to content

envoy: Add circuit breaker configuration for ingress, egress, and external envoy#44195

Merged
jrajahalme merged 2 commits intocilium:mainfrom
liyihuang:pr/liyih/envoy_max_connections
Feb 24, 2026
Merged

envoy: Add circuit breaker configuration for ingress, egress, and external envoy#44195
jrajahalme merged 2 commits intocilium:mainfrom
liyihuang:pr/liyih/envoy_max_connections

Conversation

@liyihuang
Copy link
Copy Markdown
Contributor

@liyihuang liyihuang commented Feb 4, 2026 •
edited
Loading

see commits

Added circuit breaker configuration (max connections, requests, and retries) for Cilium Envoy ingress, egress, and external envoy.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 4, 2026
@liyihuang liyihuang changed the title Pr/liyih/envoy max connections envoy: Add circuit breaker configuration for ingress, egress, and external envoy Feb 4, 2026
@liyihuang liyihuang force-pushed the pr/liyih/envoy_max_connections branch from d7aaba2 to c1082b5 Compare February 4, 2026 17:03
@liyihuang liyihuang added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. area/servicemesh GH issues or PRs regarding servicemesh release-note/misc This PR makes changes that have no direct user impact. labels Feb 4, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 4, 2026
@liyihuang
Copy link
Copy Markdown
Contributor Author

liyihuang commented Feb 4, 2026

/test

@liyihuang liyihuang requested a review from jrajahalme February 4, 2026 19:03
@liyihuang liyihuang marked this pull request as ready for review February 4, 2026 19:17
@liyihuang liyihuang requested review from a team as code owners February 4, 2026 19:17
@liyihuang liyihuang requested review from squeed and youngnick February 4, 2026 19:17
jrajahalme
jrajahalme requested changes Feb 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jrajahalme jrajahalme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helm variable names in 2nd commit are not correct.

@liyihuang liyihuang force-pushed the pr/liyih/envoy_max_connections branch from c1082b5 to 761b409 Compare February 12, 2026 11:35
@liyihuang
Copy link
Copy Markdown
Contributor Author

liyihuang commented Feb 12, 2026

/test

@liyihuang
envoy: Add circuit breakers to egress and ingress clusters
9e8666a 
Add circuit breaker configuration to both the egress and ingress Envoy clusters to limit retry attempts.

Signed-off-by: Liyi Huang <liyi.huang@isovalent.com>
@liyihuang
envoy: Add maxConnections and maxRequests to circuit breakers
08146b7 
While we have cilium#43049 to cover
embedded case. This PR is to cover the external envoy use case to use
clusterMaxRequests and clusterMaxConnections

Signed-off-by: Liyi Huang <liyi.huang@isovalent.com>
@liyihuang liyihuang force-pushed the pr/liyih/envoy_max_connections branch from 761b409 to 08146b7 Compare February 17, 2026 19:25
@liyihuang
Copy link
Copy Markdown
Contributor Author

liyihuang commented Feb 17, 2026

/test

youngnick
youngnick approved these changes Feb 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up @liyihuang.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 24, 2026
@jrajahalme jrajahalme added this pull request to the merge queue Feb 24, 2026
Merged via the queue into cilium:main with commit 3efb667 Feb 24, 2026
80 of 83 checks passed
@liyihuang liyihuang added the needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch label Mar 6, 2026
@tommyp1ckles tommyp1ckles mentioned this pull request Mar 9, 2026
Merged
7 tasks
@tommyp1ckles tommyp1ckles added backport-pending/1.19 The backport for Cilium 1.19.x for this PR is in progress. and removed needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch labels Mar 9, 2026
@github-actions github-actions bot added backport-done/1.19 The backport for Cilium 1.19.x for this PR is done. and removed backport-pending/1.19 The backport for Cilium 1.19.x for this PR is in progress. labels Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@squeed squeed squeed approved these changes

@jrajahalme jrajahalme jrajahalme approved these changes

@youngnick youngnick youngnick approved these changes

+1 more reviewer

@moemen moemen moemen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. area/servicemesh GH issues or PRs regarding servicemesh backport-done/1.19 The backport for Cilium 1.19.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@liyihuang @squeed @moemen @jrajahalme @youngnick @msune @tommyp1ckles