ginkgo: remove ClusterIP cannot be accessed externally when access is disabled#44192
Merged
joestringer merged 3 commits intomainfrom Feb 17, 2026
Merged
ginkgo: remove ClusterIP cannot be accessed externally when access is disabled#44192joestringer merged 3 commits intomainfrom
ClusterIP cannot be accessed externally when access is disabled#44192joestringer merged 3 commits intomainfrom
Conversation
ClusterIP cannot be accessed externally when access is disabled
48a699f to
5a5654a
Compare
Contributor
Author
|
/test |
Artyop
approved these changes
Feb 11, 2026
be419c9 to
7df91c6
Compare
Contributor
Author
|
/test |
christarazi
approved these changes
Feb 13, 2026
This commit has no functional changes, but it explicitly set the `--bpf-lb-external-clusterip=false` flag in the test data, to make it clear and explicit that we don't expect ClusterIP to be routable. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
bed38a9 to
0d56d14
Compare
This commits adds `tc_lb{4,6}_nonroutable_clusterip` test that ensures
packets sent from external node to a non-routable ClusterIP service
are dropped with the correct reason code DROP_IS_CLUSTER_IP and
that the metrics are updated correctly.
Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
…s disabled`
The Ginkgo test verifies that ClusterIP services are not reachable from
external (i.e., nodeWithoutCilium) when the `bpf-lb-external-clusterip` flag is
disabled. However, this behavior is already covered by:
1. `pkg/loadbalancer/tests/testdata/clusterip.txtar`, where in the LB map
we expect `FLAGS=ClusterIP+sessionAffinity+non-routable` for the service.
2. `tc_lb{4,6}_nonroutable_clusterip.c`, where we verify that an
incoming packet destined to a service w/o the SVC_FLAG_ROUTABLE is
being dropped.
Thus, this Ginkgo test can be simply removed as is.
Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
0d56d14 to
262bf7f
Compare
Contributor
Author
|
/test |
ysksuzuki
approved these changes
Feb 17, 2026
Member
ysksuzuki
left a comment
There was a problem hiding this comment.
LGTM, thanks! Just a non-blocking question.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please refer to commit messages:
Related: #44168.