Skip to content

metrics: remove agent bootstrap metrics#44180

Merged
joestringer merged 1 commit intocilium:mainfrom
mhofstetter:pr/mhofstetter/daemon-remove-bootstrap-metrics
Feb 13, 2026
Merged

metrics: remove agent bootstrap metrics#44180
joestringer merged 1 commit intocilium:mainfrom
mhofstetter:pr/mhofstetter/daemon-remove-bootstrap-metrics

Conversation

@mhofstetter
Copy link
Copy Markdown
Member

This commit removes the deprecated agent bootstrap metrics.

Hive job metrics can be used to inspect the duration of the legacy daemon initialization job. In special cases it might be worth to introduce context specific metrics - similar to what has been introduced for the endpoint restoration logic.

Deprecation PR: #43348

@mhofstetter mhofstetter added kind/cleanup This includes no functional changes. area/metrics Impacts statistics / metrics gathering, eg via Prometheus. release-note/misc This PR makes changes that have no direct user impact. area/modularization Relates to code modularization and maintenance. labels Feb 4, 2026
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/daemon-remove-bootstrap-metrics branch from 8b6df97 to 333cc46 Compare February 4, 2026 10:25
@mhofstetter
Copy link
Copy Markdown
Member Author

/test

@mhofstetter mhofstetter marked this pull request as ready for review February 4, 2026 11:21
@mhofstetter mhofstetter requested review from a team as code owners February 4, 2026 11:21
Copy link
Copy Markdown
Member

@pippolo84 pippolo84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 💯

Shouldn't this be marked as a release-note/minor given that we are removing user facing metrics?

@mhofstetter mhofstetter added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. and removed release-note/misc This PR makes changes that have no direct user impact. labels Feb 4, 2026
Copy link
Copy Markdown
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. A couple of nits inline.

@qmonnet qmonnet added the upgrade-impact This PR has potential upgrade or downgrade impact. label Feb 4, 2026
This commit removes the deprecated agent bootstrap metrics.

Hive job metrics can be used to inspect the duration of the legacy
daemon initialization job. In special cases it might be worth to
introduce context specific metrics - similar to what has been
introduced for the endpoint restoration logic.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/daemon-remove-bootstrap-metrics branch from 333cc46 to 51c85f8 Compare February 5, 2026 07:38
@mhofstetter
Copy link
Copy Markdown
Member Author

I incorporated Marco's feedback.

@mhofstetter
Copy link
Copy Markdown
Member Author

/test

Copy link
Copy Markdown
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Copy Markdown
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side, thanks

@mhofstetter
Copy link
Copy Markdown
Member Author

@chancez gentle ping 😊

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 12, 2026
@joestringer joestringer added this pull request to the merge queue Feb 13, 2026
Merged via the queue into cilium:main with commit 481c23c Feb 13, 2026
75 of 76 checks passed
@mhofstetter mhofstetter deleted the pr/mhofstetter/daemon-remove-bootstrap-metrics branch February 16, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/metrics Impacts statistics / metrics gathering, eg via Prometheus. area/modularization Relates to code modularization and maintenance. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. upgrade-impact This PR has potential upgrade or downgrade impact.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants