Skip to content

endpoint/watchdog: fetch all endpoints without programs loaded#44111

Merged
joestringer merged 1 commit intocilium:mainfrom
mhofstetter:pr/mhofstetter/ep-watchdog-improve-logging
Feb 5, 2026
Merged

endpoint/watchdog: fetch all endpoints without programs loaded#44111
joestringer merged 1 commit intocilium:mainfrom
mhofstetter:pr/mhofstetter/ep-watchdog-improve-logging

Conversation

@mhofstetter
Copy link
Copy Markdown
Member

Currently, the endpoint watchdog reloads all Cilium endpoint BPF programs as soon as it detects one endpoint without the programs loaded.

While analysing these watchdog warnings, it would be helpful to have the list of the endpoints without the programs loaded in the log message (and not just the total count of all endpoints).

Therefore, this commit slightly changes the logic and collects all endpoints without the programs loaded before reloading the programs (incl. the proper log message).

Related issue: #44078

@mhofstetter mhofstetter added the release-note/misc This PR makes changes that have no direct user impact. label Feb 2, 2026
@mhofstetter mhofstetter added needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch kind/enhancement This would improve or streamline existing functionality. labels Feb 2, 2026
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/ep-watchdog-improve-logging branch from 843a026 to 7c40e55 Compare February 2, 2026 10:17
@mhofstetter
Copy link
Copy Markdown
Member Author

/test

@mhofstetter mhofstetter marked this pull request as ready for review February 2, 2026 16:37
@mhofstetter mhofstetter requested a review from a team as a code owner February 2, 2026 16:37
@mhofstetter mhofstetter requested a review from fristonio February 2, 2026 16:37
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 3, 2026
@fristonio fristonio removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 3, 2026
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/ep-watchdog-improve-logging branch 2 times, most recently from 0ad9fc7 to 800e2ba Compare February 3, 2026 13:19
@mhofstetter
Copy link
Copy Markdown
Member Author

/test

Copy link
Copy Markdown
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve but leave the comment thread above open for your response - still seems like it would be nice to save the strings for workload names from the iteration loop to generate better logs later on.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 3, 2026
@joestringer joestringer enabled auto-merge February 3, 2026 17:40
Currently, the endpoint watchdog reloads all Cilium endpoint BPF programs
as soon as it detects one endpoint without the programs loaded.

While analysing these watchdog warnings, it would be helpful to have
the list of the endpoints without the programs loaded in the log
message (and not just the total count of all endpoints).

Therefore, this commit slightly changes the logic and collects
all endpoints without the programs loaded before reloading the
programs (incl. the proper log message).

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/ep-watchdog-improve-logging branch from 800e2ba to 525be04 Compare February 4, 2026 08:57
@mhofstetter mhofstetter removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 4, 2026
@mhofstetter
Copy link
Copy Markdown
Member Author

/test

@joestringer joestringer added this pull request to the merge queue Feb 5, 2026
@mhofstetter mhofstetter added dont-merge/bad-bot To prevent MLH from marking ready-to-merge. and removed dont-merge/bad-bot To prevent MLH from marking ready-to-merge. labels Feb 5, 2026
Merged via the queue into cilium:main with commit 3975517 Feb 5, 2026
78 checks passed
@mhofstetter mhofstetter deleted the pr/mhofstetter/ep-watchdog-improve-logging branch February 5, 2026 07:59
@Artyop Artyop mentioned this pull request Feb 10, 2026
6 tasks
@Artyop Artyop added backport-pending/1.19 The backport for Cilium 1.19.x for this PR is in progress. and removed needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch labels Feb 10, 2026
@github-actions github-actions bot added backport-done/1.19 The backport for Cilium 1.19.x for this PR is done. and removed backport-pending/1.19 The backport for Cilium 1.19.x for this PR is in progress. labels Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-done/1.19 The backport for Cilium 1.19.x for this PR is done. kind/enhancement This would improve or streamline existing functionality. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants