Skip to content

operator/multi-pool: Minor improvements to the node handler#44080

Merged
pippolo84 merged 2 commits intocilium:mainfrom
pippolo84:pr/pippolo84/operator-multi-pool-impro-2
Feb 3, 2026
Merged

operator/multi-pool: Minor improvements to the node handler#44080
pippolo84 merged 2 commits intocilium:mainfrom
pippolo84:pr/pippolo84/operator-multi-pool-impro-2

Conversation

@pippolo84
Copy link
Copy Markdown
Member

@pippolo84 pippolo84 commented Jan 30, 2026

A couple of minor improvements to the multi-pool node handler:

  1. remove direct dependency from daemon config and prefer boolean flags passed at initialization
  2. add a method to remove all controllers and test that no goroutines are leaked when the node handler is properly stopped

Related: #43937

Avoid direct dependency to daemon config in PoolAllocator. Instead, pass
the proper flags during PoolAllocator initialization.

Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
…lers

Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
@pippolo84 pippolo84 added the release-note/misc This PR makes changes that have no direct user impact. label Jan 30, 2026
@pippolo84 pippolo84 requested a review from a team as a code owner January 30, 2026 18:54
@pippolo84 pippolo84 added the area/ipam IP address management, including cloud IPAM label Jan 30, 2026
@pippolo84 pippolo84 requested a review from a team as a code owner January 30, 2026 18:54
@pippolo84 pippolo84 added the area/multipool Affects Multi-Pool IPAM label Jan 30, 2026
Copy link
Copy Markdown
Member

@HadrienPatte HadrienPatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@pippolo84
Copy link
Copy Markdown
Member Author

/test

@pippolo84 pippolo84 enabled auto-merge February 3, 2026 09:34
@pippolo84 pippolo84 added this pull request to the merge queue Feb 3, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 3, 2026
Merged via the queue into cilium:main with commit 1b91753 Feb 3, 2026
86 checks passed
@pippolo84 pippolo84 deleted the pr/pippolo84/operator-multi-pool-impro-2 branch February 3, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ipam IP address management, including cloud IPAM area/multipool Affects Multi-Pool IPAM ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants