Skip to content

deps, bgp: Bump GoBGP version to most recent v3.37 fork#44073

Merged
joestringer merged 2 commits intocilium:mainfrom
rastislavs:gobgp-bump-eor-fix
Jan 30, 2026
Merged

deps, bgp: Bump GoBGP version to most recent v3.37 fork#44073
joestringer merged 2 commits intocilium:mainfrom
rastislavs:gobgp-bump-eor-fix

Conversation

@rastislavs
Copy link
Copy Markdown
Contributor

GoBGP version bump resolving an issue with invalid advertised routes counters:

When Graceful Restart was enabled, the advertised routes counters reported one extra route (internally accounted for the GR EOR marker).

Bump GoBGP version to the most recent v3.37 cilium/gobgp fork, to pick up the fix for invalid advertised routes counters.

@rastislavs rastislavs added release-note/bug This PR fixes an issue in a previous release of Cilium. area/bgp Impacts the Border Gateway Protocol feature. needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch labels Jan 30, 2026
@rastislavs
Copy link
Copy Markdown
Contributor Author

/test

@rastislavs rastislavs marked this pull request as ready for review January 30, 2026 15:40
@rastislavs rastislavs requested review from a team as code owners January 30, 2026 15:40
Copy link
Copy Markdown
Member

@YutaroHayakawa YutaroHayakawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 30, 2026
@joestringer joestringer added this pull request to the merge queue Jan 30, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jan 30, 2026
@joestringer
Copy link
Copy Markdown
Member

@rastislavs please rebase then we can try again 🙏

@joestringer
Copy link
Copy Markdown
Member

(I would have preferred this PR to go in first to ease backports, but I didn't catch the conflict with #44067 until too late)

Bumps GoBGP to the most recent v3.37.0 fork version
to pick up a recent bgp routes stats fix.

Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
Fix incorrect advertised routes counts in the test output
caused by GoBGP issue that was fixed recently.

Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
@YutaroHayakawa
Copy link
Copy Markdown
Member

YutaroHayakawa commented Jan 30, 2026

Ok, I fixed it. Let me give it another shot.

@YutaroHayakawa
Copy link
Copy Markdown
Member

/test

@YutaroHayakawa
Copy link
Copy Markdown
Member

Conformance Gateway API (ci-gateway-api): #44043
Conformance Ginkgo (ci-ginkgo): #44082

@joestringer joestringer enabled auto-merge January 30, 2026 22:37
@joestringer joestringer added this pull request to the merge queue Jan 30, 2026
Merged via the queue into cilium:main with commit fea84ce Jan 30, 2026
75 of 76 checks passed
@rastislavs rastislavs mentioned this pull request Feb 2, 2026
4 tasks
@rastislavs rastislavs added backport-pending/1.19 The backport for Cilium 1.19.x for this PR is in progress. and removed needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch labels Feb 2, 2026
@github-actions github-actions bot removed the backport-pending/1.19 The backport for Cilium 1.19.x for this PR is in progress. label Feb 2, 2026
@github-actions github-actions bot added the backport-done/1.19 The backport for Cilium 1.19.x for this PR is done. label Feb 2, 2026
@cilium-release-bot cilium-release-bot bot moved this to Released in cilium v1.19.0 Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/bgp Impacts the Border Gateway Protocol feature. backport-done/1.19 The backport for Cilium 1.19.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.

Projects

No open projects
Status: Released

Development

Successfully merging this pull request may close these issues.

5 participants