Merged
Conversation
[ upstream commit 72c362a ] Some clusters have the admission plugin OwnerReferencesPermissionEnforcement activated. This plugin protects access to metadata.ownerReferences[x].blockOwnerDeletion, only users with the update permission to the finalizers subresource of the referenced owner can change it. This adds such permissions to the cilium-operator clusterRole, as the operator sets EnpointSlices owner references. Signed-off-by: Frederic Giloux <frederic.giloux@isovalent.com> Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
[ upstream commit 680ea6f ] This is required when the OwnerReferencesPermissionEnforcement admission plugin is set, because the operator creates CiliumEnvoyConfig resources owned by the corresponding ingress, with the blockOwnerDeletion flag set. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
[ upstream commit f682f08 ] The admission plugin OwnerReferencesPermissionEnforcement adds constraints when owner references are set. This plugin is, for instance, activated by default on OpenShift. This will help with catching permission issues in CI. Signed-off-by: Frederic Giloux <frederic.giloux@isovalent.com> Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Member
Author
|
/ci-clustermesh |
fgiloux
approved these changes
Jan 27, 2026
Member
Author
|
/test |
julianwiedmann
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ I've dropped the second commit from #43949, as it reapplied the second one from #43912, that had been previously reverted on main. I've also reordered the commits so that the one enabling the check in CI comes after the fixes.
Once this PR is merged, a GitHub action will update the labels of these PRs: