Skip to content

network driver: add CRDs CiliumNetworkDriverNodeConfig and CiliumNetworkDriverClusterConfig#44033

Merged
pippolo84 merged 2 commits intocilium:feature/dra-driverfrom
bersoare:pr/bersoare/networkdriver/operator_clusterconfig
Feb 3, 2026
Merged

network driver: add CRDs CiliumNetworkDriverNodeConfig and CiliumNetworkDriverClusterConfig#44033
pippolo84 merged 2 commits intocilium:feature/dra-driverfrom
bersoare:pr/bersoare/networkdriver/operator_clusterconfig

Conversation

@bersoare
Copy link
Copy Markdown
Contributor

@bersoare bersoare commented Jan 27, 2026

as per discussion on cilium/design-cfps#85, adding separate types for the cilium agent and operator.
changed the watch config function to filter node config by nodeName using local node name.

network driver: add CRDs CiliumNetworkDriverNodeConfig and CiliumNetworkDriverClusterConfig

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 27, 2026
@bersoare bersoare changed the title Pr/bersoare/networkdriver/operator clusterconfig network driver: add CRDs CiliumNetworkDriverNodeConfig and CiliumNetworkDriverClusterConfig Jan 27, 2026
@bersoare bersoare force-pushed the pr/bersoare/networkdriver/operator_clusterconfig branch 6 times, most recently from 6b8506b to 8f13111 Compare January 27, 2026 16:19
@bersoare
Copy link
Copy Markdown
Contributor Author

bersoare commented Jan 27, 2026

/test

YutaroHayakawa
YutaroHayakawa reviewed Jan 27, 2026
View reviewed changes
@bersoare bersoare force-pushed the pr/bersoare/networkdriver/operator_clusterconfig branch from 8f13111 to b71796b Compare January 28, 2026 09:33
@bersoare
Copy link
Copy Markdown
Contributor Author

bersoare commented Jan 28, 2026

/test

@bersoare bersoare force-pushed the pr/bersoare/networkdriver/operator_clusterconfig branch from b71796b to bed7868 Compare January 28, 2026 11:41
@bersoare
Copy link
Copy Markdown
Contributor Author

bersoare commented Jan 28, 2026

/test

@bersoare
Copy link
Copy Markdown
Contributor Author

bersoare commented Jan 28, 2026

/ci-l3-l4

@bersoare
Copy link
Copy Markdown
Contributor Author

bersoare commented Jan 28, 2026

/ci-ginkgo

@bersoare
Copy link
Copy Markdown
Contributor Author

bersoare commented Jan 28, 2026

/ci-l7

@bersoare
Copy link
Copy Markdown
Contributor Author

bersoare commented Jan 28, 2026

/ci-l3-l4

@bersoare
Copy link
Copy Markdown
Contributor Author

bersoare commented Jan 28, 2026

/ci-l7

@bersoare bersoare marked this pull request as ready for review January 29, 2026 08:59
@bersoare bersoare requested review from a team as code owners January 29, 2026 08:59
@bersoare bersoare requested review from YutaroHayakawa, aditighag and squeed and removed request for a team January 29, 2026 08:59
@bersoare
Copy link
Copy Markdown
Contributor Author

bersoare commented Jan 29, 2026

cc @YutaroHayakawa @pippolo84

@pippolo84 pippolo84 requested review from pippolo84 and removed request for a team January 30, 2026 18:58
@bersoare bersoare force-pushed the pr/bersoare/networkdriver/operator_clusterconfig branch 3 times, most recently from 02404f7 to 379038b Compare February 2, 2026 11:56
@bersoare
Copy link
Copy Markdown
Contributor Author

bersoare commented Feb 2, 2026

/test

@bersoare
Copy link
Copy Markdown
Contributor Author

bersoare commented Feb 2, 2026

/ci-kpr

@bersoare
Copy link
Copy Markdown
Contributor Author

bersoare commented Feb 2, 2026

/ci-l7

@HadrienPatte HadrienPatte removed their request for review February 2, 2026 16:01
@bersoare
Copy link
Copy Markdown
Contributor Author

bersoare commented Feb 2, 2026

/ci-kpr

YutaroHayakawa
YutaroHayakawa reviewed Feb 3, 2026
View reviewed changes
pkg/k8s/apis/cilium.io/v2alpha1/network_driver_types.go Outdated
@@ -38,6 +71,13 @@ type CiliumNetworkDriverConfig struct {
Spec CiliumNetworkDriverConfigSpec `json:"spec"`
Copy link
Copy Markdown
Member

@YutaroHayakawa YutaroHayakawa Feb 3, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, with my suggestion, the CiliumNetworkDriverConfigSpec includes nodeSelector. It's a bit odd to include the nodeSelector in the NodeConfig. It's a bit annoying, but we should introduce a new struct without the selector.

YutaroHayakawa
YutaroHayakawa approved these changes Feb 3, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@YutaroHayakawa YutaroHayakawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, it looks good to me from the API perspective. Approving here to unblock this, but please fix the last suggestion before you merge. Thanks!

pippolo84
pippolo84 approved these changes Feb 3, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@pippolo84 pippolo84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 💯

@bersoare
network driver: add CRDs for cluster and node configs
c865033 
adding the CRD types for both cilium operator
and cilium agent, in preparation
to add the configuration selection logic to the
cilium operator

make the `vfCount` field immutable

Signed-off-by: Bernardo Soares <20172413+bersoare@users.noreply.github.com>
@bersoare
network driver: change cilium agent to find the node config
f60412b 
use the new type for the node specific configuration

Signed-off-by: Bernardo Soares <20172413+bersoare@users.noreply.github.com>
@bersoare bersoare force-pushed the pr/bersoare/networkdriver/operator_clusterconfig branch from 379038b to f60412b Compare February 3, 2026 10:17
@bersoare
Copy link
Copy Markdown
Contributor Author

bersoare commented Feb 3, 2026

@pippolo84 @YutaroHayakawa
addressed yutaro's last comment. lmk what you think!

@bersoare
Copy link
Copy Markdown
Contributor Author

bersoare commented Feb 3, 2026

/test

@bersoare
Copy link
Copy Markdown
Contributor Author

bersoare commented Feb 3, 2026

/ci-eks

@bersoare
Copy link
Copy Markdown
Contributor Author

bersoare commented Feb 3, 2026

/ci-kpr

@pippolo84 pippolo84 self-requested a review February 3, 2026 14:14
@bersoare
Copy link
Copy Markdown
Contributor Author

bersoare commented Feb 3, 2026

/ci-l7

@bersoare bersoare mentioned this pull request Feb 3, 2026
Merged
@pippolo84 pippolo84 mentioned this pull request Feb 3, 2026
Merged
@pippolo84
Copy link
Copy Markdown
Member

pippolo84 commented Feb 3, 2026

Since @YutaroHayakawa already acked the PR I think it is ok to merge into the feature branch 🚀

@pippolo84 pippolo84 merged commit 9bc91a5 into cilium:feature/dra-driver Feb 3, 2026
75 of 76 checks passed
@julianwiedmann julianwiedmann added the area/dra-plugin Impacts the Cilium Network Driver DRA plugin. label Feb 11, 2026
@pippolo84 pippolo84 mentioned this pull request Mar 31, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pippolo84 pippolo84 pippolo84 approved these changes

@YutaroHayakawa YutaroHayakawa YutaroHayakawa approved these changes

@squeed squeed Awaiting requested review from squeed squeed is a code owner automatically assigned from cilium/helm

@aditighag aditighag Awaiting requested review from aditighag aditighag is a code owner automatically assigned from cilium/contributing

Assignees

No one assigned

Labels

area/dra-plugin Impacts the Cilium Network Driver DRA plugin. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bersoare @pippolo84 @YutaroHayakawa @msune @julianwiedmann