Conversation
Member
Author
|
@squeed this is related to the discussion you raised on Slack. We also discussed this topic during the weekly community meeting today. Please take a look, in particular at the commit focused on policy. @MrFreezeex I made a few minor changes to the way that the Cluster Mesh upgrade notes were written, and I believe you had commented on this topic during the community meeting so I've requested your review here too in case you were interested. |
joestringer
commented
Jan 21, 2026
joestringer
commented
Jan 21, 2026
5cdaa3f to
36d6ad8
Compare
Member
Author
|
@rgo3 FYI I added the last commit on here to address the encryption strict mode discussion we had on Slack. |
Member
Author
|
/test |
MrFreezeex
reviewed
Jan 22, 2026
Member
MrFreezeex
left a comment
There was a problem hiding this comment.
Thanks! I reviewed mostly from a Cluster Mesh perspective and looks great overall 🙏. I left one comment inline about one of the Cluster Mesh item but apart from that lgtm!
squeed
reviewed
Jan 22, 2026
Commit 882a2e9 ("cilium: Introduce datapath-mode "auto"") added this upgrade note to the v1.19 upgrade guide which breaks the docs updates going on right now for actual v1.19, plus that feature won't land until v1.20. Temporarily remove the release note to simplify the upcoming rework of the upgrade notes. Another commit soon after will reintroduce this in a new v1.20 upgrade guide section. Signed-off-by: Joe Stringer <joe@cilium.io>
The FromRequires / ToRequires fields were not removed, but instead the length of these fields was restricted to length 0. This allows us to avoid making a breaking change to the format of the resource while still enforcing that users do not use this unsupported field. Fix the upgrade note to conform with this behavior. Fixes: 4fbbc8b ("policy: Reintroduce From/ToRequires but mark them as deprecated") Signed-off-by: Joe Stringer <joe@cilium.io>
This commit creates some stronger structure around the upgrade notes in the hopes of more clearly communicating to users what is changing and when they may need to take action. The high level categories are: * Action Required * Informational Notes * Changes to Features * Changes to Metrics Furthermore, for feature flags and metrics they are now sorted in the following order: new, changed, deprecated, removed. This commit doesn't modify the text of the release notes, only rearranges the ordering. Signed-off-by: Joe Stringer <joe@cilium.io>
Member
Author
|
I applied the above feedback, rebased against main, and introduced a couple of extra commits here for v1.20 upgrade notes (since we're already starting to add those and we need to avoid the backport for those). |
36d6ad8 to
2eec532
Compare
This commit clarifies the action required from users when interacting with network policies during the v1.18 -> v1.19 upgrade. Signed-off-by: Joe Stringer <joe@cilium.io>
Clarify general wording in the upgrade notes and rearrange some of the items for new features into the relevant docs section. Signed-off-by: Joe Stringer <joe@cilium.io>
Per out-of-band discussion with Robin, update this release note to clarify when there might be packet loss related to the new encryption strict mode feature. Three changes here: - Drops could happen any time the feature is turned on or off - The disruption is only known to occur during the upgrade period - We can simplify the language to address the reader more directly. Signed-off-by: Joe Stringer <joe@cilium.io>
Add a new section for v1.20 release notes to live. This commit doesn't remove v1.19 for now until we've released the final version, in case we want to make some change on "main" and backport also to v1.19. We can clean up that section soon after the release. Signed-off-by: Joe Stringer <joe@cilium.io>
This commit reintroduces the datapath-mode=auto upgrade guide docs from commit 882a2e9 ("cilium: Introduce datapath-mode "auto""). This time it's the v1.20 upgrade notes section. Signed-off-by: Joe Stringer <joe@cilium.io>
2eec532 to
08f1cae
Compare
Member
Author
|
/test |
MrFreezeex
approved these changes
Jan 23, 2026
Member
MrFreezeex
left a comment
There was a problem hiding this comment.
Thanks! Looks great to me ClusterMesh wise :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review commit by commit.
This PR creates some stronger structure around the upgrade notes in
the hopes of more clearly communicating to users what is changing and
when they may need to take action. The high level categories are:
Furthermore, for feature flags and metrics they are now sorted in the
following order: new, changed, deprecated, removed.
Clarify general wording in the upgrade notes and rearrange some of the
items for new features into the relevant docs section. In particular,
simplify some of the language to avoid third party reference to the
reader and instead directly inform them what they need to do.
Preview 2026-01-22: https://deploy-preview-43913--docs-cilium-io.netlify.app/operations/upgrade