bpf: correct comments in cil_from_netdev function#43864
Merged
joestringer merged 1 commit intocilium:mainfrom Feb 6, 2026
Merged
bpf: correct comments in cil_from_netdev function#43864joestringer merged 1 commit intocilium:mainfrom
joestringer merged 1 commit intocilium:mainfrom
Conversation
Removed conditions from the comment block describing the cil_from_netdev function since the logic has been changed Signed-off-by: Liyi Huang <liyi.huang@isovalent.com>
db21823 to
f4a38bf
Compare
Contributor
Author
|
/test |
joestringer
approved these changes
Feb 6, 2026
Member
joestringer
left a comment
There was a problem hiding this comment.
I agree. This is not the place to document when the program is attached, exactly because it can get out-of-date like this. At best this comment should instead refer to the structure or function that determines when the program should be attached.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing conditions from the comment block describing the cil_from_netdev function since the logic has been changed.
with the current codebase, we dont have the condition to attach the cil_from_netdev for certain features.
In my test environment I dont have BPF Nodeport, Host firewall nor L2 announcements.
but I still have
when I check the loader, I can see it's just going through the devices without condition like others
https://github.com/liyihuang/cilium/blob/db2182352aae62a0178a1e3c1f858e570c847bb8/pkg/datapath/loader/host.go#L254-L257