clustermesh: exclude back non ready/non serving endpoints#43807
Merged
MrFreezeex merged 1 commit intocilium:mainfrom Jan 26, 2026
Merged
clustermesh: exclude back non ready/non serving endpoints#43807MrFreezeex merged 1 commit intocilium:mainfrom
MrFreezeex merged 1 commit intocilium:mainfrom
Conversation
Member
Author
|
/test |
3f9c05c to
ed784e9
Compare
Member
Author
|
/test |
This add back a check to skip some endpoints that should not receive any traffic in the ClusterMesh context. Before the fixed commit this filtering was done through the resource / ParseEndpointSliceV1 but this was removed so that everything can be kept it in the backend maps while the backends not supposed to serve new connections would be excluded directly by the datapath. However as ClusterMesh doesn't retain any info on the Endpoint conditions, those are essentially lost and we would propagate them like any fully ready backends unfortunately. Fixes: 6f41c98 ("loadbalancer: Keep non-serving terminating backends") Signed-off-by: Arthur Outhenin-Chalandre <git@mrfreezeex.fr>
ed784e9 to
1d062da
Compare
Member
Author
|
/test |
Member
Author
|
Ah it seems to affect v1.18 as well :/ #42708 |
Member
|
@cilium/operator / @joamaki please take a look when you get the chance 🙏 |
joamaki
approved these changes
Jan 26, 2026
10 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds back a check to skip some endpoints that should not receive anyvtraffic in the ClusterMesh context.
Before the fixed commit this filtering was done through the resource / ParseEndpointSliceV1 but this was removed so that everything can be kept it in he backend maps while backends are excluded correctly at the datapath level.
However as ClusterMesh doesn't retain any info on the Endpoint conditions, those are essentially lost and we would propagate them like any fully ready backends unfortunately.