gateway api: fix for multiple listeners on a gateway check#43802
Merged
youngnick merged 2 commits intocilium:mainfrom Jan 22, 2026
Merged
gateway api: fix for multiple listeners on a gateway check#43802youngnick merged 2 commits intocilium:mainfrom
youngnick merged 2 commits intocilium:mainfrom
Conversation
8a775ce to
2f1a10a
Compare
Contributor
|
/test |
Member
|
nice work @xtineskim should this be backported to v1.19? if yes then we should add the label btw: it seems that |
auto-merge was automatically disabled
January 16, 2026 14:43
Head branch was pushed to by a user without write access
ce0a4db to
a52928d
Compare
Member
Author
|
thanks @mhofstetter for the feedback! and yes adding the label now~ 🤝 |
Member
Author
|
/test |
aa7279e to
4b3d83a
Compare
Member
Author
|
/test |
9778787 to
183a7d1
Compare
Member
Author
|
/test |
183a7d1 to
47010c8
Compare
ede68d4 to
4731046
Compare
Member
Author
|
/test |
4731046 to
fdb9d6b
Compare
Member
Author
|
/test |
Signed-off-by: xtine <xtineskim@gmail.com>
Signed-off-by: xtine <xtineskim@gmail.com>
fdb9d6b to
22bfe39
Compare
Member
Author
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before there was a bug in which depending on the ordering of the listeners in a gateway, either all the listeners will have attached routes, or none at all.
Adding a function in helpers.go that checks if a single listener and route is valid. Updating the necessary function calls in gateway_reconcile.go, and correcting it's respective test case.
Fixes: #42013 and #43630