Skip to content

bpf, nat46x64: move RFC6052 prefix into node config#43799

Merged
ti-mo merged 1 commit intomainfrom
pr/vk/bpf/nat/cfg
Feb 10, 2026
Merged

bpf, nat46x64: move RFC6052 prefix into node config#43799
ti-mo merged 1 commit intomainfrom
pr/vk/bpf/nat/cfg

Conversation

@viktor-kurchenko
Copy link
Copy Markdown
Contributor

@viktor-kurchenko viktor-kurchenko commented Jan 15, 2026

This commit moves NAT 46x64 RFC6052 prefix bytes into the node configuration so BPF programs consume CONFIG(nat_46x64_prefix) values instead of C header defines.
The Go datapath now populates these fields from the NAT46x64 config, and the headerfile writer no longer emits NAT_46X64_PREFIX_ defines.

Updates included:

  • BPF nat_46x64 helpers switched to CONFIG(nat_46x64_prefix).
  • Node config population moved to runtime config and legacy defines dropped.

@viktor-kurchenko viktor-kurchenko added area/loader Impacts the loading of BPF programs into the kernel. area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. labels Jan 15, 2026
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/ci-verifier

@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/ci-verifier

@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

@viktor-kurchenko viktor-kurchenko marked this pull request as ready for review January 16, 2026 08:32
@viktor-kurchenko viktor-kurchenko requested review from a team as code owners January 16, 2026 08:32
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

jrife
jrife previously requested changes Jan 22, 2026
Copy link
Copy Markdown
Contributor

@ti-mo ti-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Jordan pointed out, let's use v4addr for this fields, that's what they're for! 😉 I'm working on making dpgen output Go types for C structs as well, but it's not quite ready.

@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/bpf/nat/cfg branch 2 times, most recently from c4269ee to 10c62de Compare February 4, 2026 15:09
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

@ti-mo
Copy link
Copy Markdown
Contributor

ti-mo commented Feb 5, 2026

@viktor-kurchenko Sorry, looks like this needs a rebase.

@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

@ti-mo ti-mo dismissed jrife’s stale review February 5, 2026 12:02

Feedback addressed

@ti-mo ti-mo enabled auto-merge February 5, 2026 12:02
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

Rebased to resolve conflicts.

@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

@ti-mo ti-mo added this pull request to the merge queue Feb 9, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 9, 2026
This commit moves NAT 46x64 RFC6052 prefix bytes into the node
configuration so BPF programs consume CONFIG(nat_46x64_prefix) value
instead of C header defines.
The Go datapath now populates this field from the NAT46x64 config, and
the headerfile writer no longer emits NAT_46X64_PREFIX_ defines.

Updates included:

- BPF nat_46x64 helpers switched to CONFIG(nat_46x64_prefix).
- Node config population moved to runtime config and legacy defines
  dropped.

Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

Rebased to resolve conflicts.

@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

@ti-mo ti-mo added this pull request to the merge queue Feb 10, 2026
Merged via the queue into main with commit b156a3a Feb 10, 2026
508 of 514 checks passed
@ti-mo ti-mo deleted the pr/vk/bpf/nat/cfg branch February 10, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/loader Impacts the loading of BPF programs into the kernel. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants