Skip to content

v1.17 Backports 2026-01-15#43778

Merged
gandro merged 2 commits intocilium:v1.17from
gandro:pr/v1.17-backport-2026-01-15-10-21
Jan 15, 2026
Merged

v1.17 Backports 2026-01-15#43778
gandro merged 2 commits intocilium:v1.17from
gandro:pr/v1.17-backport-2026-01-15-10-21

Conversation

@gandro
Copy link
Copy Markdown
Member

@gandro gandro commented Jan 15, 2026

Once this PR is merged, a GitHub action will update the labels of these PRs:

 43717 43745

aanm and others added 2 commits January 15, 2026 10:21
[ upstream commit 8a2c681 ]

The call-publish-helm job calls a reusable workflow (release.yaml) which
needs to sign Helm charts using cosign with GitHub Actions OIDC tokens.

According to GitHub Actions documentation[1]:

> If jobs.<job_id>.permissions is not specified in the calling job, the
  called workflow will have the default permissions for the GITHUB_TOKEN.

Since the default permissions don't include 'id-token: write', cosign
was unable to obtain OIDC tokens and fell back to device flow, which
then failed with expired_token errors.

[1]: https://docs.github.com/en/actions/using-workflows/reusing-workflows

Fixes: 32d801791fdd ("workflows: Add id-token permission to call-publish-helm job")
Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
[ upstream commit 6a39648 ]

Adjust the branch name in the URL to get the latest stable Hubble CLI
version.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
@gandro gandro added kind/backports This PR provides functionality previously merged into master. backport/1.17 This PR represents a backport for Cilium 1.17.x of a PR that was merged to main. labels Jan 15, 2026
@gandro gandro requested review from aanm and tklauser January 15, 2026 09:22
@gandro gandro marked this pull request as ready for review January 15, 2026 09:22
@gandro gandro requested review from a team as code owners January 15, 2026 09:22
@gandro gandro requested a review from nebril January 15, 2026 09:22
@gandro
Copy link
Copy Markdown
Member Author

gandro commented Jan 15, 2026

/test

@gandro gandro enabled auto-merge January 15, 2026 09:54
@gandro gandro added this pull request to the merge queue Jan 15, 2026
Merged via the queue into cilium:v1.17 with commit a30e088 Jan 15, 2026
73 of 74 checks passed
@gandro gandro deleted the pr/v1.17-backport-2026-01-15-10-21 branch January 15, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/1.17 This PR represents a backport for Cilium 1.17.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants