endpoint/manager: wait for completed endpoint restoration before starting periodic GC & regeneration controllers #43776
Merged
julianwiedmann merged 1 commit intocilium:mainfrom Jan 15, 2026
Conversation
256ea65 to
38776aa
Compare
38776aa to
93f9599
Compare
Member
Author
|
/test |
gandro
approved these changes
Jan 15, 2026
Currently, the periodic controllers for endpoint garbage collection and endpoint regeneration are registered at startup - without waiting for the completion of the endpoint restoration (incl. regeneration) at startup. This might lead to problems where the premature endpoint regeneration interfers with the endpoint restoration (incl. processing the deletion queue). This commit fixes this by moving the controller registration into a hive job that waits for the completion of the endpoint restoration. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
93f9599 to
f0f31ee
Compare
Member
Author
|
rebased after merging dependent PR. re-requesting reviews and undrafted. |
gandro
approved these changes
Jan 15, 2026
Member
Author
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the periodic controllers for endpoint garbage collection and endpoint
regeneration are registered at startup - without waiting for the completion
of the endpoint restoration (incl. regeneration) at startup.
This might lead to problems where the premature endpoint regeneration interfers
with the endpoint restoration (incl. processing the deletion queue).
This commit fixes this by moving the controller registration into a hive job
that waits for the completion of the endpoint restoration.
Builds on top of another bugfix: #43790
Note: Refactoring the logic to use Hive Jobs instead of controllers will be done in a follow up PR