clustermesh: add missing reason in mcs condition metrics#43775
Merged
MrFreezeex merged 1 commit intomainfrom Jan 16, 2026
Merged
clustermesh: add missing reason in mcs condition metrics#43775MrFreezeex merged 1 commit intomainfrom
MrFreezeex merged 1 commit intomainfrom
Conversation
Reason is a field defined with a fixed possible set of values so it makes a good candidate to be added in those metrics. Signed-off-by: Arthur Outhenin-Chalandre <git@mrfreezeex.fr>
Member
Author
|
/test |
qmonnet
approved these changes
Jan 15, 2026
giorio94
approved these changes
Jan 15, 2026
chancez
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason is a field defined with a fixed possible set of values so it makes a good candidate to be added in those metrics.
I have marked this for backport in 1.19 as it's a small addition to the existing metrics and allows users to have more info about the condition (for instance the the type of conflict in some alerts) and also those metrics are net new from 1.19 (as it doesn't really count as a bug fix if you feel it isn't reasonable to backport this please say so, it could also wait for 1.20 ~)