endpoint/restore: remove special handling for host endpoint in case of ipsec#43757
Merged
julianwiedmann merged 1 commit intocilium:mainfrom Jan 20, 2026
Conversation
Member
Author
|
/test |
Member
Author
|
Requesting review from @pchaigno. Do we need any additional changes (VinE related) or is it fine to simply delete that code? |
fristonio
approved these changes
Jan 15, 2026
Member
|
This looks fine to me, but I'd rather have Louis's review here as he authored the VinE work. |
Contributor
|
Awesome catch @mhofstetter ! Yes this is safe to go now that we are in a VinE steady state moving forward. |
…f ipsec Currently, we regenerate the host endpoint before all other restored endpoints if IPSec is enabled. This might be problematic as it increases the overall time for the endpoint restoration - and might lead to issues if Envoy prematurely configures Envoy before all Endpoints are restored (default after 3 min). It looks like this code / special handling is no longer needed with v1.19. Let's remove it. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
00eca08 to
5759f8a
Compare
Member
Author
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we regenerate the host endpoint before all other restored endpoints if IPSec is enabled.
This might be problematic as it increases the overall time for the endpoint restoration - and might lead to issues if Envoy prematurely configures Envoy before all Endpoints are restored (default after 3 min).
It looks like this code / special handling is no longer needed with v1.19. Let's remove it.
PR that (re-)introduced the temporary special-handling: #37723