Exclude topology.kubernetes.io labels by default#43725
Merged
aanm merged 1 commit intocilium:mainfrom Jan 14, 2026
Merged
Conversation
Starting from version 1.35 Kuberentes propagetes topology.kubernetes.io labels from nodes to pods. This causes CID duplication and can lead to CID exhaustion. This patch adds !topology.kubernetes.io label filter to default label filters Fixes: cilium#43723 Signed-off-by: Maciej Moscicki <mmoscicki@google.com>
Member
|
I'll at least nominate this for 1.19 backport, but we may want to think about backports to earlier releases as well (while balancing the risk). That said this is not a review, will defer to others on that for now. |
|
Commit a542840 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
3 tasks
a542840 to
c61bdf0
Compare
squeed
approved these changes
Jan 14, 2026
Contributor
|
/test |
Contributor
|
I'm strongly in favor of backporting this; it's not really a "code change" as much as it is a configuration update. Unexpected identity churn can quickly destabilize a cluster. |
Member
|
/test |
Contributor
Additionally, labels in the |
|
What a change! Good job @moscicky |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from version 1.35 Kuberentes propagetes topology.kubernetes.io labels from nodes to pods. This causes CID duplication and can lead to CID exhaustion.
This patch adds !topology.kubernetes.io label filter to default label filters
Fixes: #43723