Skip to content

bpf: consistently use proto extracted from packet as __be16#43720

Merged
tklauser merged 1 commit intomainfrom
pr/tklauser/bpf-proto-be16
Jan 14, 2026
Merged

bpf: consistently use proto extracted from packet as __be16#43720
tklauser merged 1 commit intomainfrom
pr/tklauser/bpf-proto-be16

Conversation

@tklauser
Copy link
Copy Markdown
Member

In these cases, proto is always in network byte order extracted from the packet using validate_ethertype() and used as such inside the functions. Consistently declare it as __be16 to make this obvious to the reader.

In these cases, proto is always in network byte order extracted from the
packet using validate_ethertype() and used as such inside the functions.
Consistently declare it as __be16 to make this obvious to the reader.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser requested review from a team as code owners January 13, 2026 14:05
@tklauser tklauser added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/cleanup This includes no functional changes. labels Jan 13, 2026
@tklauser tklauser requested a review from sayboras January 13, 2026 14:05
@tklauser tklauser added the release-note/misc This PR makes changes that have no direct user impact. label Jan 13, 2026
@tklauser tklauser requested review from jrife and smagnani96 January 13, 2026 14:05
@tklauser tklauser added the dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs label Jan 13, 2026
@tklauser
Copy link
Copy Markdown
Member Author

/test

@tklauser tklauser enabled auto-merge January 13, 2026 15:43
Copy link
Copy Markdown
Contributor

@smagnani96 smagnani96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 💯

Copy link
Copy Markdown
Contributor

@jrife jrife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup, thanks!

@aanm aanm removed the dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs label Jan 14, 2026
@tklauser tklauser added this pull request to the merge queue Jan 14, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Jan 14, 2026
Merged via the queue into main with commit 53c075a Jan 14, 2026
456 of 461 checks passed
@tklauser tklauser deleted the pr/tklauser/bpf-proto-be16 branch January 14, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants