chore: add get-runner-ip github action#43694
Closed
sekhar-isovalent wants to merge 1 commit intocilium:mainfrom
Closed
chore: add get-runner-ip github action#43694sekhar-isovalent wants to merge 1 commit intocilium:mainfrom
sekhar-isovalent wants to merge 1 commit intocilium:mainfrom
Conversation
Contributor
Author
|
/test |
Signed-off-by: Sekhar Sankaramanchi <sekhar@isovalent.com>
02e4780 to
a55bc9d
Compare
Contributor
|
So I know Joe wasn't a big fan of JS, this could also be implemented in python |
Member
|
Go > Python > JS just from a maintainer skills perspective. |
|
This pull request has been automatically marked as stale because it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the effort to harden cluster creation and restrict API Server access (not expose to public internet), It makes sense to create an action that will fetch the runner-ip from a specified source and return it.