operator: Remove AWS deprecated options#43693
Merged
pippolo84 merged 2 commits intocilium:mainfrom Jan 23, 2026
Merged
Conversation
8ba85c3 to
ec6033c
Compare
ec6033c to
a0f0121
Compare
a0f0121 to
c771c8e
Compare
c771c8e to
91e8c44
Compare
Member
Author
|
/test |
tklauser
requested changes
Jan 21, 2026
Member
tklauser
left a comment
There was a problem hiding this comment.
One comment inline about also removing the ProviderFlagsHooks interface. Other than that LGTM, thanks!
tklauser
requested changes
Jan 21, 2026
91e8c44 to
a513233
Compare
Member
Author
|
/test |
Remove deprecated AWS AWSPaginationEnabled option. Also, move AWSMaxResultsPerCall into the AWS IPAM cell. AWSMaxResultsPerCall was kept as a global operator option to keep the backward compatibility with the AWSPaginationEnabled logic, but since that has been removed MaxResultsPerCall can be treated just like any other AWS option. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
The hooks to register additional operator global flags had the sole purpose to support cloud vendor specific options needed when a cloud vendor specific IPAM mode was requested. Since all the IPAM allocators have been modularized alongside their options, the hooks are not needed anymore and can be removed. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
a513233 to
73729b2
Compare
Member
Author
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove deprecated AWS
AWSPaginationEnabledoption. Also, moveAWSMaxResultsPerCallinto the AWS IPAM cell.AWSMaxResultsPerCallwas kept as a global operator option to keep the backward compatibility with theAWSPaginationEnabledlogic, but since that has been removedAWSMaxResultsPerCallcan be treated just like any other AWS option.Also, remove the operator flag hooks to register cloud-vendor specific global options.
Depends on #43628