Add support for wildcard specifier anywhere in SNI pattern#43674
Merged
fristonio merged 3 commits intocilium:mainfrom Feb 17, 2026
Merged
Add support for wildcard specifier anywhere in SNI pattern#43674fristonio merged 3 commits intocilium:mainfrom
fristonio merged 3 commits intocilium:mainfrom
Conversation
e52154f to
f199c81
Compare
Member
Author
|
/test |
c5c65a5 to
ad6442b
Compare
Member
Author
ad6442b to
8652f49
Compare
Member
Author
|
/test |
mhofstetter
approved these changes
Feb 16, 2026
squeed
approved these changes
Feb 16, 2026
aanm
approved these changes
Feb 16, 2026
Member
aanm
left a comment
There was a problem hiding this comment.
LGTM, the only missing thing is the bump in the CRD schema
This commit relaxes k8s api validation pattern for server names in policy api to allow wildcard specifiers anywhere in SNI pattern. This allows users to write more compressed network policies and is inline with the syntax supported in FQDN match pattern. With this change users can now specify allowed server names with wildcard as: - '**.cilium.io': Existing behavior which matches any number of subdomain levels in the prefix. "test.cilium.io" and "test.app.cilium.io" matches but "cilium.io" does not. - '*.cilium.io': Existing behavior which matches all subdomains of cilium.io on a single level. "test.cilium.io" matches but "test.app.cilium.io" and "cilium.io" do not. - 'sub*.cilium.io': Matches subdomains of cilium.io where the subdomain component begins with "sub"(only one level). "sub.cilium.io" and "subdomain.cilium.io" matches wile "www.cilium.io", "cilium.io" and "test.subdomain.cilium.io" do not. Additionally this commit introduces a new helper function used to sanitize server names pattern when converting to envoy protobuf. This is required because cilium-envoy doesn't support the same semantics for match pattern syntax as DNS match pattern in cilium-agent. Signed-off-by: Deepesh Pathak <deepesh.pathak@isovalent.com>
Signed-off-by: Deepesh Pathak <deepesh.pathak@isovalent.com>
Signed-off-by: Deepesh Pathak <deepesh.pathak@isovalent.com>
8652f49 to
6ec04cb
Compare
Member
Author
|
/test |
jrajahalme
approved these changes
Feb 17, 2026
gandro
approved these changes
Feb 17, 2026
christarazi
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit message for more details.
Depends On: cilium/proxy#1693
Fixes #43597