gh: e2e-upgrade: test patch releases#43627
Merged
julianwiedmann merged 4 commits intomainfrom Jan 20, 2026
Merged
Conversation
Member
Author
|
@aanm if you have a moment, wanna give this a quick look to see if there's any surprises here? The first two patches mostly. |
aanm
approved these changes
Jan 8, 2026
Member
aanm
left a comment
There was a problem hiding this comment.
@julianwiedmann first two commits LGTM
aanm
requested changes
Jan 8, 2026
Member
aanm
left a comment
There was a problem hiding this comment.
Ah, looking at the remaining 3 patches. This patched looked familiar. I didn't double check but I believe the tests-e2e-upgrade is missing the ipsec key rotation? See the changes in https://github.com/cilium/cilium/pull/40437/changes
aanm
approved these changes
Jan 8, 2026
Member
aanm
left a comment
There was a problem hiding this comment.
oh, this is the tests-ipsec-upgrade.yaml, not the conformance-ipsec-e2e.yaml. Then it should be good then.
a806f07 to
2c945cb
Compare
2c945cb to
d9fe89b
Compare
Member
Author
|
/test |
d9fe89b to
bbe2442
Compare
Member
Author
|
/test |
Member
Author
|
The branch has a temporary commit to allow for testing of the workflows. I'll drop it before merging. |
Customize the downgrade version and image tag as needed. And skip most of the workflow when no downgrade version is available (since we don't test patch releases on the main branch). Note that this doesn't introduce additional testing, since we still only generate matrix entries with 'minor' mode. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
… tests `skip-upgrade` is meant for situations where the `old` release doesn't support a certain config setting, and thus we should only test the PR branch. Assume that this doesn't apply for patch release testing. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Start generating matrix entries with 'patch' mode. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
This has now been fully integrated into the e2e-upgrade workflow. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
bbe2442 to
79cc2c7
Compare
Member
Author
|
/test |
aanm
approved these changes
Jan 20, 2026
smagnani96
approved these changes
Jan 20, 2026
Contributor
smagnani96
left a comment
There was a problem hiding this comment.
LGTM, left some thoughts mostly for myself to understand better.
79cc2c7 to
97c76c7
Compare
Member
Author
|
/test |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far we've been doing upgrade testing for
ipsec-upgradeworkflow.Add the needed bits for patch-level testing to e2e-upgrade, and enable it for all e2e configs. Then remove the ipsec-upgrade workflow.
Patch-level testing happened in #43751, and will subsequently land in v1.19 through that PR.
Fixes: #31932