Skip to content

chore(install): explicitly set hostUsers where necessary#43615

Merged
julianwiedmann merged 1 commit intocilium:mainfrom
jcpunk:mandatory-hostusers
Jan 16, 2026
Merged

chore(install): explicitly set hostUsers where necessary#43615
julianwiedmann merged 1 commit intocilium:mainfrom
jcpunk:mandatory-hostusers

Conversation

@jcpunk
Copy link
Copy Markdown
Contributor

@jcpunk jcpunk commented Jan 7, 2026 •
edited by mhofstetter
Loading

Setting hostUsers: false might not be supported on all kubernetes distributions, but for sure the listed containers cannot perform their tasks unless hostUsers is true.

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!
Explicitly set `hostUsers: true` on containers where user namespaces would break the runtime.

@jcpunk jcpunk requested review from a team as code owners January 7, 2026 20:37
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 7, 2026
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jan 7, 2026
@jcpunk jcpunk force-pushed the mandatory-hostusers branch 3 times, most recently from 2b36319 to ba5d3d1 Compare January 7, 2026 21:22
@jcpunk jcpunk requested a review from a team as a code owner January 7, 2026 21:22
@jcpunk jcpunk requested a review from joestringer January 7, 2026 21:22
@joestringer
Copy link
Copy Markdown
Member

joestringer commented Jan 7, 2026

/test

@joestringer joestringer added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Jan 7, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 7, 2026
mhofstetter
mhofstetter approved these changes Jan 8, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mhofstetter mhofstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

fyi: i moved the change description into the release-note code-block in the PR description

@jcpunk
chore(install): explicitly set hostUsers where necessary
ccc1d10 
Setting `hostUsers: false` might not be supported on all
kubernetes distributions, but for sure the listed containers
cannot perform their tasks unless hostUsers is `true`.

Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
@jcpunk jcpunk force-pushed the mandatory-hostusers branch from ba5d3d1 to ccc1d10 Compare January 8, 2026 14:53
@xtineskim
Copy link
Copy Markdown
Member

xtineskim commented Jan 8, 2026

/test

@joestringer joestringer added the dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs label Jan 9, 2026
@aanm aanm removed the dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs label Jan 14, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 16, 2026
@julianwiedmann julianwiedmann added this pull request to the merge queue Jan 16, 2026
Merged via the queue into cilium:main with commit e5719c7 Jan 16, 2026
75 of 76 checks passed
@jcpunk jcpunk deleted the mandatory-hostusers branch January 16, 2026 14:27
@joestringer joestringer mentioned this pull request Jan 16, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhofstetter mhofstetter mhofstetter approved these changes

@tklauser tklauser tklauser approved these changes

@joestringer joestringer joestringer approved these changes

@Artyop Artyop Artyop approved these changes

Assignees

No one assigned

Labels

kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@jcpunk @joestringer @xtineskim @tklauser @mhofstetter @Artyop @aanm @julianwiedmann