Skip to content

operator: Remove dummy ingress endpoint#43558

Merged
mhofstetter merged 2 commits intocilium:mainfrom
joamaki:pr/joamaki/remove-dummy-ingress-endpoint
Feb 12, 2026
Merged

operator: Remove dummy ingress endpoint#43558
mhofstetter merged 2 commits intocilium:mainfrom
joamaki:pr/joamaki/remove-dummy-ingress-endpoint

Conversation

@joamaki
Copy link
Copy Markdown
Contributor

@joamaki joamaki commented Jan 5, 2026 •
edited by mhofstetter
Loading

Now that v1.18 is out with the new LB control-plane we can finally remove the dummy ingress endpoint.

Fixes: #19262

The dummy endpoint (192.192.192.192:9999) is no longer created for Ingress and Gateway API.

@joamaki joamaki requested a review from sayboras January 5, 2026 09:55
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 5, 2026
@joamaki joamaki force-pushed the pr/joamaki/remove-dummy-ingress-endpoint branch from dc03832 to 9eff324 Compare January 5, 2026 09:56
@sayboras
Copy link
Copy Markdown
Member

sayboras commented Jan 5, 2026

/ci-ingress

@sayboras
Copy link
Copy Markdown
Member

sayboras commented Jan 5, 2026

/ci-gateway-api

sayboras
sayboras approved these changes Jan 5, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@sayboras sayboras added kind/cleanup This includes no functional changes. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Jan 5, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 5, 2026
@sayboras
Copy link
Copy Markdown
Member

sayboras commented Jan 5, 2026

/test

@julianwiedmann julianwiedmann mentioned this pull request Jan 5, 2026
Merged
3 tasks
@joamaki joamaki marked this pull request as ready for review January 6, 2026 07:56
@joamaki joamaki requested review from a team as code owners January 6, 2026 07:56
julianwiedmann
julianwiedmann reviewed Jan 7, 2026
View reviewed changes
@joestringer
Copy link
Copy Markdown
Member

joestringer commented Jan 9, 2026

@joamaki were you intending to land this in v1.19? Given reviews are all in and there's just an unresolved comment to look into, it seems like it could match the criteria for a feature freeze exception:

- Multiple committers consider that the benefit of merging the PR in
  violation of the freeze outweighs the risks introduced by merging
  the proposal.
- The PR is self-contained or requires minimal subsequent changes in
  order to complete the functionality outlined in the PR.
- The author is actively working on the PR to drive it to completion.
- The testsuite has been run against the PR and there are no major
  shortfalls in testing.
- A committer has already reviewed the overall goals of the PR and
  it is not expected to be controversial.

(I see there is possible upgrade impact under discussion, if you think so then please also set the upgrade-impact label. This does not necessarily exclude it from merge for upcoming release, but depending on that discussion we may want to do additional regression testing prior to the release if you push for this to be part of 1.19).

@joestringer
Copy link
Copy Markdown
Member

joestringer commented Jan 9, 2026

Proposing for 1.19 blocker for now, but if it doesn't need to go in then feel free to remove again and set dont-merge/wait-until-release label.

@joestringer joestringer added the release-blocker/1.19 This issue will prevent the release of the next version of Cilium. label Jan 9, 2026
@joamaki
Copy link
Copy Markdown
Contributor Author

joamaki commented Jan 9, 2026

Removing the release blocker and moving this back to draft. We'll need to have a good strategy for dealing with removing the dummy endpoints created by prior versions that also works with downgrading.

@joamaki joamaki marked this pull request as draft January 9, 2026 11:47
@joamaki joamaki added dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs and removed release-blocker/1.19 This issue will prevent the release of the next version of Cilium. labels Jan 9, 2026
@aanm aanm removed the dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs label Jan 14, 2026
@mhofstetter mhofstetter force-pushed the pr/joamaki/remove-dummy-ingress-endpoint branch from 9eff324 to eb66b57 Compare February 12, 2026 08:20
@mhofstetter
Copy link
Copy Markdown
Member

mhofstetter commented Feb 12, 2026 •
edited
Loading

Re-added Helm managed EndpointSlice that is used for shared Ingresses. (but still without the dummy endpoint in it!)

@joamaki @mhofstetter
loadbalancer: Remove dummy ingress endpoint workaround
43c17fa 
Remove the skipping of the 192.192.192.192:9999 dummy ingress
endpoint as the next commit will remove the creation of it.

Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@joamaki @mhofstetter
operator/helm: Remove creation of dummy ingress endpoint
d47c890 
With the new agent load-balancer implementation the dummy endpoint
is no longer necessary. Now that v1.18 has been released with that
implementation we can remove the creation of the dummy endpoint
without breaking upgrade.

Note: This commit removes the dummy endpoint in the Operator-
(Gateway API & dedicated Ingress) & Helm- (shared Ingress) managed
`EndpointSlice`'s. The creation of the `EndpointSlice` itself will
will be done in a separate PR.

Fixes: cilium#19262

Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter force-pushed the pr/joamaki/remove-dummy-ingress-endpoint branch from eb66b57 to d47c890 Compare February 12, 2026 08:22
@mhofstetter
Copy link
Copy Markdown
Member

mhofstetter commented Feb 12, 2026

Rebased on top of main

@mhofstetter
Copy link
Copy Markdown
Member

mhofstetter commented Feb 12, 2026

/test

@mhofstetter mhofstetter marked this pull request as ready for review February 12, 2026 08:59
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 12, 2026
@mhofstetter mhofstetter added this pull request to the merge queue Feb 12, 2026
Merged via the queue into cilium:main with commit 38881b5 Feb 12, 2026
77 checks passed
@mhofstetter mhofstetter mentioned this pull request Feb 12, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhofstetter mhofstetter mhofstetter approved these changes

@julianwiedmann julianwiedmann julianwiedmann approved these changes

@dylandreimerink dylandreimerink dylandreimerink approved these changes

@jrajahalme jrajahalme jrajahalme approved these changes

@sayboras sayboras sayboras approved these changes

@Artyop Artyop Artyop approved these changes

Assignees

No one assigned

Labels

kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ingress: Investigate if it's possible to remove dummy endpoint

10 participants

@joamaki @sayboras @joestringer @mhofstetter @dylandreimerink @jrajahalme @Artyop @julianwiedmann @msune @aanm