hubble: add support for SCTP metrics#43535
Merged
gandro merged 1 commit intocilium:mainfrom Jan 26, 2026
Merged
Conversation
7ed1af3 to
e45d8ea
Compare
|
Commit e45d8ea does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
e45d8ea to
1fb3ac4
Compare
1fb3ac4 to
273abea
Compare
d21eda7 to
508f580
Compare
508f580 to
afb377f
Compare
joestringer
approved these changes
Jan 4, 2026
Member
joestringer
left a comment
There was a problem hiding this comment.
The docs changes look good to me, but this will need a look from the hubble reviewers for proper review.
Given that v1.19 feature freeze is imminent (ref), we will likely defer this into the v1.20 development cycle.
chancez
approved these changes
Jan 13, 2026
Jack-R-lantern
commented
Jan 16, 2026
Member
Author
|
/test |
Contributor
|
Ping @cilium/sig-hubble-api |
Contributor
|
@Jack-R-lantern Could you update the release note snippet from the description or remove it altogether if the title is good enough? |
Member
Author
A brief description has been added to the release notes. |
SCTP manages connection state using Chunk Types. SCTP Chunk Types are transmitted in the payload, not in the header. Based on RFC 4960, Section 6.10 (Bundling), all control chunks must appear first in the SCTP packet payload. According to the specification, INIT, INIT_ACK, and SHUTDOWN_COMPLETE must not be bundled with any other chunks. Due to the rule that control chunks must always come first, SHUTDOWN and SHUTDOWN_ACK cannot be bundled with DATA chunks. However, control chunks can be bundled together. As a result, SHUTDOWN and SHUTDOWN_ACK may be missed in certain cases. Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>
afb377f to
bceabf6
Compare
Member
Author
|
/test |
gandro
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.
Description
SCTPmanages connection state using Chunk Types.SCTP Chunk Types are transmitted in the payload, not in the header.
Based on RFC 4960, Section 6.10 (Bundling), all control chunks must appear first in the SCTP packet payload.
According to the specification, INIT, INIT_ACK, and SHUTDOWN_COMPLETE must not be bundled with any other chunks.
Due to the rule that control chunks must always come first, SHUTDOWN and SHUTDOWN_ACK cannot be bundled with DATA chunks.
However, control chunks can be bundled together.
As a result, SHUTDOWN and SHUTDOWN_ACK may be missed in certain cases.
Test Scenario
Test Result
Fixes: #23347