bpf, tunnel: TUNNEL_PORT and TUNNEL_PROTOCOL to runtime config#43520
Merged
bpf, tunnel: TUNNEL_PORT and TUNNEL_PROTOCOL to runtime config#43520
Conversation
b4b861c to
acb79ed
Compare
Contributor
Author
|
/test |
acb79ed to
18aaed7
Compare
Contributor
Author
|
/test |
d0b66be to
972d79f
Compare
Contributor
Author
|
/test |
777ebc0 to
cb0b82b
Compare
Contributor
Author
|
/test |
cb0b82b to
c761cda
Compare
Contributor
Author
|
/test |
c761cda to
f17d3a5
Compare
Contributor
Author
|
/test |
ti-mo
reviewed
Jan 12, 2026
Contributor
ti-mo
left a comment
There was a problem hiding this comment.
Thanks! The naming of the constants and their type doesn't make much sense to me, but looks good overall. Wondering if this can't be made into a non-node-config, but not sure where this value is actually needed around the code base.
33 tasks
f17d3a5 to
b9c90af
Compare
ti-mo
approved these changes
Jan 26, 2026
Contributor
ti-mo
left a comment
There was a problem hiding this comment.
Looks good, one nit. (avoid overly terse descriptions in general)
ab6d016 to
aa04bad
Compare
Contributor
Author
Roger that! Thanks! I've also squashed the commits. |
aa04bad to
e7826f4
Compare
Contributor
Author
|
/test |
e7826f4 to
5cd03ea
Compare
Contributor
Author
|
/test |
Contributor
Author
|
Rebased on the latest main branch. |
ti-mo
approved these changes
Feb 2, 2026
smagnani96
approved these changes
Feb 2, 2026
Contributor
smagnani96
left a comment
There was a problem hiding this comment.
Left a comment, not sure about declaring those configs in bpf/lib/classifiers.h.
Other than that, PR LGTM, thanks 💯
This commit moves `TUNNEL_PORT` and `TUNNEL_PROTOCOL` from compile-time macros to runtime config values, wiring them through local node config and the BPF config structs. Also it replaces macro-based helpers with inline functions for tunnel classification and header setup, and updates BPF tests to assign the new config values explicitly. Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
This commit drops the unused `TUNNEL_SRC_PORT_LOW` and `TUNNEL_SRC_PORT_HIGH` defines from the datapath config provider. This commit also removes the associated datapath provider tests that validated these defines. Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
5cd03ea to
6fc9b2c
Compare
Contributor
Author
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate TUNNEL_PORT and TUNNEL_PROTOCOL to runtime config.
Please see description per-commit.
Related: #38370