Skip to content

bpf: Migrate IDENTITY_LEN, IDENTITY_MAX to runtime config#43507

Merged
ti-mo merged 1 commit intomainfrom
pr/vk/bpf/runtime/cfg/identity
Jan 26, 2026
Merged

bpf: Migrate IDENTITY_LEN, IDENTITY_MAX to runtime config#43507
ti-mo merged 1 commit intomainfrom
pr/vk/bpf/runtime/cfg/identity

Conversation

@viktor-kurchenko
Copy link
Copy Markdown
Contributor

@viktor-kurchenko viktor-kurchenko commented Dec 27, 2025

Migrate IDENTITY_LEN, IDENTITY_MAX to runtime config.

Please see description per-commit.

Related: #38370

@viktor-kurchenko viktor-kurchenko added the release-note/misc This PR makes changes that have no direct user impact. label Dec 27, 2025
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

1 similar comment
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

@cilium-ariane
Copy link
Copy Markdown

cilium-ariane bot commented Dec 27, 2025

Failed to retrieve pull request: pull request is not open

@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

3 similar comments
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/bpf/runtime/cfg/identity branch from e3ebaa7 to 0a3336e Compare December 28, 2025 10:15
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/bpf/runtime/cfg/identity branch 2 times, most recently from 4cabe62 to 6baa5c5 Compare December 28, 2025 12:48
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

@viktor-kurchenko viktor-kurchenko marked this pull request as ready for review December 28, 2025 13:32
@viktor-kurchenko viktor-kurchenko requested review from a team as code owners December 28, 2025 13:32
@viktor-kurchenko viktor-kurchenko added area/loader Impacts the loading of BPF programs into the kernel. area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. labels Dec 30, 2025
@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/bpf/runtime/cfg/identity branch from 6baa5c5 to ca237ac Compare January 4, 2026 09:37
@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/bpf/runtime/cfg/identity branch from c349e08 to 4973263 Compare January 9, 2026 15:48
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

Copy link
Copy Markdown
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, changes look good to me. I'd suggest squashing the two commits together, adapting the commit message as appropriate, given that the vast majority of the changes in the first are immediately reverted in the second.

@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/bpf/runtime/cfg/identity branch from 4973263 to b0e71fc Compare January 9, 2026 21:10
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

I'd suggest squashing the two commits together, adapting the commit message as appropriate, given that the vast majority of the changes in the first are immediately reverted in the second.

Makes sense! Done.

@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

@ti-mo ti-mo added this to the clang-free milestone Jan 12, 2026
Copy link
Copy Markdown
Contributor

@ti-mo ti-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left some suggestions.

@aanm aanm removed the dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs label Jan 14, 2026
@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/bpf/runtime/cfg/identity branch from b0e71fc to e6bc45a Compare January 16, 2026 10:18
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/bpf/runtime/cfg/identity branch from e6bc45a to 87173e4 Compare January 16, 2026 11:33
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/bpf/runtime/cfg/identity branch from 87173e4 to dee0f46 Compare January 21, 2026 08:18
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

Rebased on the latest main.

@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

@ti-mo @dylandreimerink kind ping)

This commit replaces the previous compile-time IDENTITY_LEN macros with
runtime configuration derived from cluster ID bits, and removes the
legacy helpers and defaults:
- add node config plumbing for cluster_id_bits and derive
  LOCAL_IDENTITY_BITS/LOCAL_IDENTITY_MAX
- update clustermesh and identity BPF helpers to use
  CONFIG(identity_len)/new macros
- remove obsolete CLUSTERMESH_HELPERS defaults and compile-time headers
- update datapath config wiring and add a cluster ID bits getter
- adjust BPF tests to set identity length via runtime config

Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/bpf/runtime/cfg/identity branch from dee0f46 to 3ee322c Compare January 25, 2026 10:48
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

/test

@ti-mo ti-mo added this pull request to the merge queue Jan 26, 2026
Merged via the queue into main with commit 60e10e9 Jan 26, 2026
462 of 463 checks passed
@ti-mo ti-mo deleted the pr/vk/bpf/runtime/cfg/identity branch January 26, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/loader Impacts the loading of BPF programs into the kernel. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants