Skip to content

bpf: Migrate CILIUM_NET_IFINDEX, CILIUM_NET_MAC, CILIUM_HOST_IFINDEX, CILIUM_HOST_MAC to runtime config#43474

Merged
julianwiedmann merged 5 commits intomainfrom
pr/vk/bpf/cilium/ifindex/cfg
Jan 21, 2026
Merged

bpf: Migrate CILIUM_NET_IFINDEX, CILIUM_NET_MAC, CILIUM_HOST_IFINDEX, CILIUM_HOST_MAC to runtime config#43474
julianwiedmann merged 5 commits intomainfrom
pr/vk/bpf/cilium/ifindex/cfg

Conversation

@viktor-kurchenko
Copy link
Copy Markdown
Contributor

@viktor-kurchenko viktor-kurchenko commented Dec 21, 2025 •
edited
Loading

Migrate CILIUM_NET_IFINDEX, CILIUM_NET_MAC, CILIUM_HOST_IFINDEX, CILIUM_HOST_MAC to runtime config.

Please see description per-commit.

Related: #38370

@viktor-kurchenko viktor-kurchenko added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. area/loader Impacts the loading of BPF programs into the kernel. labels Dec 21, 2025
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

viktor-kurchenko commented Dec 21, 2025

/test

@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/bpf/cilium/ifindex/cfg branch from b20c227 to 0153d2d Compare December 22, 2025 08:26
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

viktor-kurchenko commented Dec 22, 2025

/test

@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/bpf/cilium/ifindex/cfg branch from 15fcd1a to a768900 Compare December 22, 2025 12:02
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

viktor-kurchenko commented Dec 22, 2025

/test

@viktor-kurchenko viktor-kurchenko changed the title bpf: Migrate CILIUM_NET/HOST_IFINDEX/MAC to runtime config bpf: Migrate CILIUM_NET_IFINDEX, CILIUM_HOST_IFINDEX to runtime config Dec 22, 2025
@viktor-kurchenko viktor-kurchenko marked this pull request as ready for review December 22, 2025 12:45
@viktor-kurchenko viktor-kurchenko requested review from a team as code owners December 22, 2025 12:45
ti-mo
ti-mo reviewed Dec 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ti-mo ti-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left a few comments.

@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/bpf/cilium/ifindex/cfg branch 2 times, most recently from 8d80207 to ff31e9e Compare December 23, 2025 17:36
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

viktor-kurchenko commented Dec 23, 2025

/test

1 similar comment
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

viktor-kurchenko commented Dec 23, 2025

/test

@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/bpf/cilium/ifindex/cfg branch from fb60624 to c05b468 Compare December 25, 2025 11:33
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

viktor-kurchenko commented Dec 25, 2025

/test

2 similar comments
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

viktor-kurchenko commented Dec 25, 2025

/test

@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

viktor-kurchenko commented Dec 26, 2025

/test

@viktor-kurchenko viktor-kurchenko changed the title bpf: Migrate CILIUM_NET_IFINDEX, CILIUM_HOST_IFINDEX to runtime config bpf: Migrate CILIUM_NET_IFINDEX, CILIUM_NET_MAC, CILIUM_HOST_IFINDEX, CILIUM_HOST_MAC to runtime config Dec 27, 2025
gandro
gandro approved these changes Jan 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for my CODEOWNERs

@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/bpf/cilium/ifindex/cfg branch from e54d90f to 837c89c Compare January 12, 2026 15:08
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

viktor-kurchenko commented Jan 12, 2026

/test

@ti-mo ti-mo added this to the clang-free milestone Jan 12, 2026
@ti-mo ti-mo mentioned this pull request Jan 12, 2026
Closed
8 tasks
tommyp1ckles
tommyp1ckles reviewed Jan 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@tommyp1ckles tommyp1ckles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just had one question.

@viktor-kurchenko
bpf: migrate CILIUM_NET_IFINDEX to runtime config
8ddd9fa 
Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
@viktor-kurchenko
bpf: migrate CILIUM_HOST_IFINDEX to runtime config
11681ae 
Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
@viktor-kurchenko
datapath: localnodeconfig remove safenetlink
2f809bb 
The commit replaces safenetlink with statedb which already contains
information about network interfaces.

Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
@viktor-kurchenko
bpf: migrate CILIUM_HOST_MAC to runtime config
e4113dd 
Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
@viktor-kurchenko
bpf: migrate CILIUM_NET_MAC to runtime config
f54b4d4 
Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
@viktor-kurchenko viktor-kurchenko force-pushed the pr/vk/bpf/cilium/ifindex/cfg branch from 837c89c to f54b4d4 Compare January 13, 2026 07:26
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

viktor-kurchenko commented Jan 13, 2026

/test

@ti-mo ti-mo mentioned this pull request Jan 14, 2026
Open
33 tasks
@aanm aanm removed the dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs label Jan 14, 2026
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

viktor-kurchenko commented Jan 15, 2026

@ldelossa @tommyp1ckles kind ping)

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 18, 2026
@julianwiedmann
Copy link
Copy Markdown
Member

julianwiedmann commented Jan 21, 2026

There's still an unresolved comment hiding in this PR somewhere ...

@julianwiedmann julianwiedmann added this pull request to the merge queue Jan 21, 2026
@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

viktor-kurchenko commented Jan 21, 2026

There's still an unresolved comment hiding in this PR somewhere ...

Resolved)

Merged via the queue into main with commit 9bdf851 Jan 21, 2026
484 of 508 checks passed
@julianwiedmann julianwiedmann deleted the pr/vk/bpf/cilium/ifindex/cfg branch January 21, 2026 08:01
@julianwiedmann
Copy link
Copy Markdown
Member

julianwiedmann commented Jan 22, 2026

@viktor-kurchenko looking at #43901, I see that ipsec-e2e for this PR (https://github.com/cilium/cilium/actions/runs/20948622917) took 5(!) attempts to go green (with the same issue). Let's please not do this - if it takes use five attempts for this PR, then after it's merged everyone else will also need five attempts.

@viktor-kurchenko
Copy link
Copy Markdown
Contributor Author

viktor-kurchenko commented Jan 22, 2026

@viktor-kurchenko looking at #43901, I see that ipsec-e2e for this PR (https://github.com/cilium/cilium/actions/runs/20948622917) took 5(!) attempts to go green (with the same issue). Let's please not do this - if it takes use five attempts for this PR, then after it's merged everyone else will also need five attempts.

I have no idea where my head was when I did it. Sorry, ACK.

@julianwiedmann julianwiedmann mentioned this pull request Jan 22, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gandro gandro gandro approved these changes

@ti-mo ti-mo ti-mo approved these changes

@ldelossa ldelossa ldelossa approved these changes

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

@sayboras sayboras sayboras approved these changes

@youngnick youngnick youngnick approved these changes

@fristonio fristonio fristonio approved these changes

Assignees

No one assigned

Labels

area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/loader Impacts the loading of BPF programs into the kernel. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Milestone

clang-free

Development

Successfully merging this pull request may close these issues.