bpf: runtime config for KERNEL_HZ and ENABLE_JIFFIES#43112
Merged
Conversation
328db49 to
7931b7f
Compare
Contributor
Author
|
/test |
1 similar comment
Contributor
Author
|
/test |
ab68b88 to
c0f3ae4
Compare
Contributor
Author
|
/test |
4288917 to
8276cb4
Compare
Contributor
Author
|
/test |
ti-mo
reviewed
Dec 4, 2025
Contributor
ti-mo
left a comment
There was a problem hiding this comment.
Thanks for taking this on! I've left some comments for small potential improvements to our time API.
8276cb4 to
c7b9151
Compare
Contributor
Author
|
/test |
c7b9151 to
e247d92
Compare
Contributor
Author
|
/test |
1 similar comment
Contributor
Author
|
/test |
Contributor
|
Hi @viktor-kurchenko, should probably go directly to NODE_CONFIG in this commit |
Contributor
Author
Hi @harsimran-pabla, do you mean to squash the following commits: |
Contributor
Yes that's right. |
ce822d1 to
cfe1571
Compare
Contributor
Author
|
/test |
Contributor
Author
Done! |
harsimran-pabla
approved these changes
Dec 8, 2025
ti-mo
approved these changes
Dec 15, 2025
Contributor
ti-mo
left a comment
There was a problem hiding this comment.
Thanks, this cleans up the API nicely! Left a few comments.
cfe1571 to
fa32443
Compare
Contributor
Author
|
/test |
rastislavs
approved these changes
Dec 16, 2025
2f8dc9b to
0232d9e
Compare
Contributor
Author
|
/test |
Contributor
|
@viktor-kurchenko Looks like I introduced a merge conflict, would you be able to rebase? Please squash this down to 2 commits, one being the config migration and the other the header cleanups. |
We have just a few time-helper macros that are spread across time and mono headers. The commit moves all macros from the mono header into the time header and removes the mono header. The motivation here is to keep all time helper code in a single header file. The `ENABLE_JIFFIES` and `KERNEL_HZ` have been migrated to runtime configuration. The helper time macros were converted into regular C functions to be able to use read `enable_jiffies` and `kernel_hz` runtime properties using `CONFIG` macro. The `ktime_get_ns` and `jiffies` (translates to `jiffies64`) macros are overwritten into conntrack_test. To make it work properly, they must be defined before the time header getd included, otherwise preprocessor statements can be out of order. Also, dead code removed. Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
The `jiffies` macro is used only in a single place in the time header. Let's remove it and use the `jiffies64` function as is. Also, `kernel_hz` sentinel value: 1 removed. This should be fine now because `kernel_hz` property has been migrated to runtime configuration and `division by zero` error can be caught at compile time. Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
0232d9e to
679a228
Compare
Contributor
Author
|
/test |
Contributor
Author
Done! |
63 tasks
33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see description per commit.
Related to: #38370