Skip to content

Further GC ratchet test fix races #43075

Merged
borkmann merged 1 commit intocilium:mainfrom
tommyp1ckles:pr/tp/gc-ratchet-fix-races-v3
Jan 21, 2026
Merged

Further GC ratchet test fix races #43075
borkmann merged 1 commit intocilium:mainfrom
tommyp1ckles:pr/tp/gc-ratchet-fix-races-v3

Conversation

@tommyp1ckles
Copy link
Copy Markdown
Contributor

@tommyp1ckles tommyp1ckles commented Dec 2, 2025

Running these tests over several times with -race still reveals some race conditions. Let's improve the reliability of these tests by fixing those.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 2, 2025
@tommyp1ckles tommyp1ckles force-pushed the pr/tp/gc-ratchet-fix-races-v3 branch 2 times, most recently from 7bf1ab2 to d8b60d2 Compare December 4, 2025 16:16
@tommyp1ckles tommyp1ckles changed the title [DRAFT] Further GC ratchet fix races Further GC ratchet fix races Dec 4, 2025
@tommyp1ckles tommyp1ckles added the release-note/ci This PR makes changes to the CI. label Dec 4, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 4, 2025
@tommyp1ckles tommyp1ckles marked this pull request as ready for review December 4, 2025 16:17
@tommyp1ckles tommyp1ckles requested a review from a team as a code owner December 4, 2025 16:17
@tommyp1ckles tommyp1ckles force-pushed the pr/tp/gc-ratchet-fix-races-v3 branch from d8b60d2 to 1c3a828 Compare December 4, 2025 16:19
@tommyp1ckles
Copy link
Copy Markdown
Contributor Author

/test

@tommyp1ckles tommyp1ckles changed the title Further GC ratchet fix races Further GC ratchet test fix races Dec 4, 2025
@tommyp1ckles tommyp1ckles force-pushed the pr/tp/gc-ratchet-fix-races-v3 branch from 1c3a828 to 68d7c13 Compare December 5, 2025 19:18
@tommyp1ckles
Copy link
Copy Markdown
Contributor Author

/test

@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jan 15, 2026
We need to correctly synchronize around feedSignals before cleaning up
the feeder channel. As well, we want to avoid races around mutating the
*gc between feeders so we now shallow copy that and pass that separately
to feeders so we can safely swap out the signals channel.

This was evident when rerunning the test a couple times with -race
enabled:

```
go test -v -count=1000 -race -failfast
```

Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
@tommyp1ckles tommyp1ckles force-pushed the pr/tp/gc-ratchet-fix-races-v3 branch from 68d7c13 to b882a37 Compare January 21, 2026 00:35
@tommyp1ckles
Copy link
Copy Markdown
Contributor Author

/test

@tommyp1ckles tommyp1ckles removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jan 21, 2026
@borkmann borkmann merged commit 460e9f4 into cilium:main Jan 21, 2026
77 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature/conntrack release-note/ci This PR makes changes to the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants