Further GC ratchet test fix races #43075
Merged
borkmann merged 1 commit intocilium:mainfrom Jan 21, 2026
Merged
Conversation
7bf1ab2 to
d8b60d2
Compare
d8b60d2 to
1c3a828
Compare
Contributor
Author
|
/test |
1c3a828 to
68d7c13
Compare
Contributor
Author
|
/test |
|
This pull request has been automatically marked as stale because it |
We need to correctly synchronize around feedSignals before cleaning up the feeder channel. As well, we want to avoid races around mutating the *gc between feeders so we now shallow copy that and pass that separately to feeders so we can safely swap out the signals channel. This was evident when rerunning the test a couple times with -race enabled: ``` go test -v -count=1000 -race -failfast ``` Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
68d7c13 to
b882a37
Compare
Contributor
Author
|
/test |
ysksuzuki
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running these tests over several times with
-racestill reveals some race conditions. Let's improve the reliability of these tests by fixing those.